Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(installer): skip unstable headless update #3338

Merged
merged 6 commits into from Oct 31, 2022

Conversation

kylo252
Copy link
Collaborator

@kylo252 kylo252 commented Oct 25, 2022

Description

  • refactor(installer): skip unstable headless update
  • fix(installer): verify that packer is installed
  • refactor(packer): skip dodgy snapshot feature

fixes #3358, #3311

How Has This Been Tested?

see #3338 (comment)

@kylo252 kylo252 changed the title fix(packer): run packer recompile on cache_reset refactor(installer): skip unstable headless update Oct 29, 2022
@kylo252 kylo252 marked this pull request as ready for review October 29, 2022 10:30
@LostNeophyte
Copy link
Member

LostNeophyte commented Oct 30, 2022

some problems with the backups:

without --overwrite

  • any run: empty ignore file is added to LUNARVIM_CONFIG_DIR.old (but it happened before this pr as well, not sure it it's needed)
  • 1st run: (may be related to the next one) empty LUNARVIM_RUNTIME_DIR.old is created (when no LUNARVIM_RUNTIME_DIR was present before)
  • 2nd run: LUNARVIM_RUNTIME_DIR is backed up to LUNARVIM_RUNTIME_DIR.old/data(name 'data' probably comes from the last folder in LUNARVIM_RUNTIME_DIR) and not LUNARVIM_RUNTIME_DIR
  • 3rd run:
    • overrides LUNARVIM_CONFIG_DIR
    • says it backed up LUNARVIM_BASE_DIR but it just deleted it leaving LUNARVIM_BASE_DIR.old untouched
    • gives an error and stops at LUNARVIM_RUNTIME_DIR (I think it should check if .old files exist before doing any backups and error out if they exist)

with --overwrite

  • 1st run: (same as before) empty LUNARVIM_RUNTIME_DIR.old is created (when no LUNARVIM_RUNTIME_DIR was present before)
  • 2nd run:
    • LUNARVIM_BASE_DIR, LUNARVIM_CONFIG_DIR are backed up and LUNARVIM_RUNTIME_DIR.old has an empty 'data' sub directory

@LostNeophyte
Copy link
Member

Now the only problem i can see now is if you have the backups already and you run the installer without overwrite, it will still run mv. I personally think it should abort the install in that case and tell the user to use overwrite if they don't need backups or someting like that.

@kylo252 kylo252 merged commit 74ad56f into LunarVim:master Oct 31, 2022
@kylo252 kylo252 deleted the packer-tweaks branch October 31, 2022 15:27
tomazursic pushed a commit to tomazursic/LunarVim that referenced this pull request Nov 1, 2022
* upstream/master:
  perf(treesitter): disable in big files (LunarVim#3268)
  fix(breadcrumbs) Performance issue, change CursorMoved event to CursorHoldI (LunarVim#3357)
  chore: bump plugins version (LunarVim#3368)
  fix(alpha): make startify sections always appear (LunarVim#3371)
  fix(lsp): only launch installed servers (LunarVim#3366)
  fix(defaults): don't use smartindent (LunarVim#3363)
  fix: statusline and breadcrumbs hls reload with config reload (LunarVim#3376)
  refactor(installer): skip unstable headless update (LunarVim#3338)
  chore(plugins): bump plugins version (LunarVim#3364)
  chore: bump plugins version (LunarVim#3276)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

E492: Not an editor command: PackerSync
3 participants