Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lsp): only launch installed servers #3366

Merged
merged 1 commit into from Oct 31, 2022

Conversation

cpea2506
Copy link
Member

@cpea2506 cpea2506 commented Oct 29, 2022

Description

Do not run lsp setup on server that is not installed when automatic_installation is disabled

Screenshot 2022-10-30 at 06 27 31

@cpea2506 cpea2506 requested a review from kylo252 October 29, 2022 23:36
Copy link
Collaborator

@kylo252 kylo252 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kylo252 kylo252 changed the title fix(lsp): launch setup only on installed server fix(lsp): only launch installed servers Oct 31, 2022
@kylo252 kylo252 merged commit a54d872 into LunarVim:master Oct 31, 2022
@k4z4n0v4
Copy link
Contributor

k4z4n0v4 commented Oct 31, 2022

This prevents LSPs present in PATH but not installed through Mason from starting. Reverting the change brings everything back to a working state.

tomazursic pushed a commit to tomazursic/LunarVim that referenced this pull request Nov 1, 2022
* upstream/master:
  perf(treesitter): disable in big files (LunarVim#3268)
  fix(breadcrumbs) Performance issue, change CursorMoved event to CursorHoldI (LunarVim#3357)
  chore: bump plugins version (LunarVim#3368)
  fix(alpha): make startify sections always appear (LunarVim#3371)
  fix(lsp): only launch installed servers (LunarVim#3366)
  fix(defaults): don't use smartindent (LunarVim#3363)
  fix: statusline and breadcrumbs hls reload with config reload (LunarVim#3376)
  refactor(installer): skip unstable headless update (LunarVim#3338)
  chore(plugins): bump plugins version (LunarVim#3364)
  chore: bump plugins version (LunarVim#3276)
@cpea2506 cpea2506 deleted the fix/lsp-manger-setup branch November 14, 2022 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants