Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.12.0 breaks --no-colour #49

Closed
lembacon opened this issue Dec 21, 2018 · 3 comments
Closed

0.12.0 breaks --no-colour #49

lembacon opened this issue Dec 21, 2018 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@lembacon
Copy link

Provided a file named test.md with the following contents:

_lorem_ **ipsum** dolor **sit** _amet_

With mdcat 0.11.0, mdcat --no-colour test.md outputs lorem ipsum dolor sit amet which is expected.

However, with mdcat 0.12.0, mdcat --no-colour test.md outputs the following:

lorem

ipsum
 dolor
sit

amet

which seems unexpected.

@swsnr
Copy link
Owner

swsnr commented Dec 21, 2018

I don’t know, I don’t use —no-colour myself. I refactored a lot and perhaps I broke it.

I’ll fix this at some point perhaps, but not anytime soon. I’m sorry but as said I don’t use this myself, and I just don’t have time for this now.

@swsnr swsnr closed this as completed in 910b1a0 Dec 24, 2018
@swsnr
Copy link
Owner

swsnr commented Dec 24, 2018

@lembacon Oh, this was a very stupid mistake of mine 🤦‍♂️ I fixed it and added a test to hopefully not break it again. I'm about to release 0.12.1 with the fix included, so you can update the Homebrew formula again.

Sorry for the hassle 😞

@swsnr swsnr added the bug Something isn't working label Dec 24, 2018
@swsnr swsnr self-assigned this Dec 24, 2018
@lembacon
Copy link
Author

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants