Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback if strikethrough isn't supported #73

Closed
swsnr opened this issue Mar 30, 2019 · 2 comments
Closed

Fallback if strikethrough isn't supported #73

swsnr opened this issue Mar 30, 2019 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@swsnr
Copy link
Owner

swsnr commented Mar 30, 2019

iTerm2 and Terminal.app don't support strikethrough text; we should have a good fallback.

Currently the text just renders like normal text which isn't so good probably.

Follow up from #71.
@swsnr swsnr added bug Something isn't working help wanted Extra attention is needed labels Mar 30, 2019
swsnr added a commit that referenced this issue Mar 30, 2019
@swsnr
Mention missing fallback
7f0e98a 
See GH-73
@norman-abramovitz
Copy link
Contributor

ITerm2 does support strikethrough in version 3.3.7 at least. I am wondering if it is a profile setting that might need to be changed.

Screen Shot 2019-12-31 at 4 35 15 PM

@norman-abramovitz
Copy link
Contributor

It actually looks like pulldown_cmark supports strikethrough already

Screen Shot 2019-12-31 at 4 45 04 PM

@swsnr swsnr closed this as completed Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@swsnr @norman-abramovitz