Refactor terminal representation again #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove Terminal trait in favour of a TerminalCapabilities struct, and explicitly pattern match over supported capabilities while rendering. This removes boxing and dynamic dispatch, and makes different features and internal behaviour like HTTP access more explicit. We now also explicitly check what and how certain features are supported while rendering; this gets rids of the NotSupportedError thing and the kludge to handle it in a special way which I never quite liked. Also simply how we check for access to resources: Remove the resource enum and instead use Url directly. Via the scheme an URL already tells us whether it’s local or not, so we just rely on the scheme and file path conversion now. This makes resolving references in markdown files and checking access much simpler.
Fix compiler warnings with --no-default-features by removing unused code.
Use empty bindings instead of drop to mark variables as used
Only iterm2 actually uses it. Fixes unused warning when compiling only with terminology.
[ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
Terminaland dynamic dispatch withTerminalCapabilitiesand static dispatch. Also allows for less complicated and more accurate conditional compilation.