Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework MonitorObserver API #49

Closed
swsnr opened this issue May 28, 2012 · 0 comments
Closed

Rework MonitorObserver API #49

swsnr opened this issue May 28, 2012 · 0 comments
Assignees
@swsnr
Labels
testsuite
Milestone
0.16

Comments

@swsnr
Copy link
Contributor

swsnr commented May 28, 2012

Just like #47, the MonitorObserver API needs to be reworked to remove the explicit action argument.

Implementation

  • Call the callback with the device only.
  • Wrap callbacks with two arguments in a closure that explicitly passes device.action as first argument.
  • ~~Emit a DeprecationWarning if a callback with two arguments is passed to MonitorObserver.~~~
  • ✔ Add callback argument taking a single argument.
  • ✔ Deprecate event_handler argument.
@ghost ghost assigned swsnr May 28, 2012
@swsnr swsnr closed this as completed in adc89b3 Jun 20, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swsnr swsnr

Labels
testsuite
Projects
None yet
Milestone
0.16
Development

No branches or pull requests
1 participant
@swsnr