filtering comment findings now, still not editing existing comment #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freeqaz
approved these changes
Apr 12, 2022
| * | ||
| */ | ||
| const types_1 = require("./types"); | ||
| function sortBySeverity(a, b) { |
There was a problem hiding this comment.
nuke this file please (the whole build folder)
| const dummyObject = {}; | ||
|
|
||
| const v8Handler = Error.prepareStackTrace; | ||
| Error.prepareStackTrace = function (dummyObject, v8StackTrace) { |
There was a problem hiding this comment.
Nit that we should add to the linter: If you don't use an anonymous function, it should be named.
| @@ -4,7 +4,7 @@ | |||
| "private": true, | |||
| "dependencies": { | |||
| "@aws-sdk/client-s3": "^3.52.0", | |||
| "@lunatrace/lunatrace-common": "link:../common", | |||
| "@lunatrace/lunatrace-common": "workspace:~", | |||
There was a problem hiding this comment.
the linter seems to be complaining about this. Are you sure this is the correct syntax?
![dev-lunatrace-by-lunasec[bot]](https://avatars.githubusercontent.com/in/179126?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are now using Reviews in "comment" mode instead of straight comments. They are updated instead of duplicated.
@freeqaz I rolled back most of the changes you made when you copy pasted the code, and then for the backend used hasura's return data from the
InsertScanmutation instead of the input data because the shape was much more similar to what the frontend was seeing, and we could request IgnoredVulnerabilities simultaneously which we needed.