Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach to form result in unwanted side effect of form submission #1

Closed
eimiveritas opened this issue Mar 4, 2019 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@eimiveritas
Copy link

Hi,

Thanks for the great lib, i have been finding time picker library to use for my reactjs app, and this is by far the most suitable.

However, there seems to be a bug/unwanted side effect from picking a time in a form.

When you put the input in a form, and set in the option to attach clocklet to the parent, it results in the form submitting after you pick a time. After much digging i found out that this is because all the minute/hour hands are buttons, which didn't specify type="button", therefore resulting in the default behaviour of submitting a form its in.

I have seen through your source code, i believe a potential change to add type="button" is in ClockletDial.

@luncheon
Copy link
Owner

luncheon commented Mar 4, 2019

Thank you for reporting the issue.
It is exactly as you said.
I will fix it soon.

@luncheon luncheon added the bug Something isn't working label Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants