Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkboxes break with browserSync #90

Open
wafflepie opened this issue Jul 16, 2018 · 3 comments
Open

Checkboxes break with browserSync #90

wafflepie opened this issue Jul 16, 2018 · 3 comments

Comments

@wafflepie
Copy link
Collaborator

Similar to react-component/checkbox#13

I suggest adding

            browserSync.create().init(
                {
                    ui: false,
                    ghostMode: false,
                    ...config,
                },
                resolve
            );

to react-union-scripts/scripts/startDevServer.js, because a consistently working application is IMO better than this feature (or make ghostMode opt-in via a config option).

@tommmyy
Copy link
Collaborator

tommmyy commented Nov 7, 2019

@wafflepie is this still true?

@wafflepie
Copy link
Collaborator Author

Probably, but it needs to be verified. I've looked through browser sync commits and couldn't find anything related.

@wafflepie
Copy link
Collaborator Author

I seriously doubt that anybody uses ghost mode anyway for React Union development, so it's probably safer to disable this to avoid weird / hard to reproduce bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants