Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unicode domain names #319

Merged
merged 8 commits into from Mar 11, 2019
Merged

Conversation

MihaZupan
Copy link
Collaborator

Fixes #316

IDNA encoding is not used on standard1.1 and portable as explained here.

@xoofx
Copy link
Owner

xoofx commented Mar 11, 2019

Thanks! I think we should drop support for netstandard1.1 then and switch to the minimum netstandard version supporting this.

@MihaZupan
Copy link
Collaborator Author

Portable as well or only std1.1?

@xoofx
Copy link
Owner

xoofx commented Mar 11, 2019

yeah, we can remove portable as well.

@xoofx
Copy link
Owner

xoofx commented Mar 11, 2019

btw, I wanted to add you as a collaborator of markdig? (instead of a contributor as it is today) you will have a bit more access to the project (moderate issues...etc.), as you have been quite involved, I was wondering if you would be interested?

@MihaZupan
Copy link
Collaborator Author

Of course, thank you :)

@xoofx
Copy link
Owner

xoofx commented Mar 11, 2019

This line can be likely removed:

https://github.com/lunet-io/markdig/blob/f8df3c80e16e98ffe0a0ce8a9a5b7b0f4c345b2f/src/Markdig/Markdown.cs#L20

Haven't checked further, but you can double check (I just did a search on GitHub search, might not be complete!)

@MihaZupan
Copy link
Collaborator Author

I tried, looks like uap10 falls under netstandard11 as far as that check is concerned and it doesn't support the alternative

@xoofx
Copy link
Owner

xoofx commented Mar 11, 2019

I tried, looks like uap10 falls under netstandard11 as far as that check is concerned and it doesn't support the alternative

Han ok

@xoofx
Copy link
Owner

xoofx commented Mar 11, 2019

Oh, also, as I forgot whenever I have to compile the changelog.md, can you add a new line for the next version about this fix in changelog.md (with a WIP on the version so that we know what to integrate)

@xoofx xoofx merged commit 354db6b into xoofx:master Mar 11, 2019
@MihaZupan MihaZupan deleted the allow-unicode-domain-names branch March 11, 2019 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants