Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SessionLocaleGuesser doe not check if the session has been started #198

Closed
NeilWhitworth opened this issue Nov 27, 2017 · 0 comments
Closed

SessionLocaleGuesser doe not check if the session has been started #198

NeilWhitworth opened this issue Nov 27, 2017 · 0 comments

Comments

@NeilWhitworth
Copy link
Contributor

Using the SessionLocaleGuesser will always cause Symfony to start a session. This causes issues when sessions are not required (i.e Anonymous Users. http://symfony.com/app.php/doc/current/session/avoid_session_start.html)
NeilWhitworth added a commit to NeilWhitworth/LocaleBundle that referenced this issue Nov 27, 2017
@NeilWhitworth
Stop sessions from being created if not already started. Fixes luneti…
e6cd367 
…cs-org#198
lunetics added a commit that referenced this issue Feb 3, 2018
@lunetics
Merge pull request #199 from NeilWhitworth/master
11de2c1 
Stop sessions from being created if not already started. Fixes #198
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NeilWhitworth