Skip to content
This repository has been archived by the owner on Nov 30, 2023. It is now read-only.

Add a tone number Pinyin field #56

Open
PandaScience opened this issue Apr 7, 2019 · 4 comments · May be fixed by #206
Open

Add a tone number Pinyin field #56

PandaScience opened this issue Apr 7, 2019 · 4 comments · May be fixed by #206

Comments

@PandaScience
Copy link

PandaScience commented Apr 7, 2019

Is your feature request related to a problem? Please describe.
I just started out learning Mandarin last week and immediately found Anki and your really great chinese-support addon. Thanks for maintaining! I also bought the Hanping Pro dictionary app on Android which I think has some really nice sound database. However, as far as I can see you can only combine Anki+Hanping using sth. like

<a href='android-app://com.embermitre.hanping.app.pro#Intent;action=com.hanpingchinese.cmn.intent.action.PLAY;S.p={{text:Pinyin}};S.s={{text:Simplified}};S.t={{text:Traditional}};S.LANG=cmn;S._SOURCE=anki;end'>

in cards, where S.p seems to be the important part for it to work. Unfortunately, it only takes pinyin in numbered form.

Describe the solution you'd like
Could you please add to config.json another field, e.g. NumPinyin, that will be filled with the corresponding numbered pinyin instead of the one with converted tone markings? That would also be helpful for cards with {{type:NumPinyin}} when learning with "simple" keyboards.

I would do it myself and provide a pull request, but because of lack of documentation it's somehow hard to go through your code.

Describe alternatives you've considered
Writing a JavaScript converter in each card's code.

@jdlorimer jdlorimer added this to the v1.0 milestone Apr 10, 2019
@jdlorimer jdlorimer self-assigned this Apr 10, 2019
@jdlorimer
Copy link
Owner

On the face of it, I think this would be straightforward to add. Give me a few days.

@jdlorimer
Copy link
Owner

Or months.

@jdlorimer jdlorimer changed the title Numbered Pinyin Field Add a tone number Pinyin field Dec 16, 2019
@PandaScience
Copy link
Author

Or years 😆

PandaScience pushed a commit to PandaScience/chinese-support-redux that referenced this issue May 22, 2022
PandaScience pushed a commit to PandaScience/chinese-support-redux that referenced this issue May 23, 2022
PandaScience pushed a commit to PandaScience/chinese-support-redux that referenced this issue May 23, 2022
PandaScience pushed a commit to PandaScience/chinese-support-redux that referenced this issue May 23, 2022
PandaScience pushed a commit to PandaScience/chinese-support-redux that referenced this issue May 23, 2022
PandaScience pushed a commit to PandaScience/chinese-support-redux that referenced this issue May 23, 2022
PandaScience pushed a commit to PandaScience/chinese-support-redux that referenced this issue May 23, 2022
@PandaScience PandaScience linked a pull request May 23, 2022 that will close this issue
@PandaScience
Copy link
Author

I just started with anki/chinese again this week and found this old issue. Had some free time today and gave it a shot. Seems to work, at least for my purpose 😉 (PR #206)

PandaScience added a commit to PandaScience/chinese-support-redux that referenced this issue May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants