Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gate] Transformation of messages mode node/topic depending on json #402

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

BiliouriV
Copy link
Contributor

@BiliouriV BiliouriV commented Nov 10, 2022

PR Description section

Description and dependencies

Gate modification in order to send a message in 2 different modes when passing the bootloader messages: NODEIDACK if in the json there is a node defined, TOPIC otherwise.

Changes

Please choose the relevant options:

  • Bug fix (non-breaking change which fixes an issue)

Related issue(s)

Provide a list of the related issues that will be fixed by this PR.


WARNING: Do not edit the checklist below.


Developer section

  • [Documentation] is up to date with new feature
  • [Tests] are passed OK (non regression, new features & bug fixes)
  • [Code Quality] please check if:
    • Each function has a header (description, inputs, outputs)
    • Code is commented (particularly in hard to understand areas)
    • There are no new warnings that can be corrected
    • Commits policy is respected (constitancy commits, clear commits comments)

QA section

  • [Review] tests for new features have been reviewed
  • [Changelog] is up-to-date with expected tags
    🆕 Feature: [Feature] Description...
    🆕 Added: [Feature] Description...
    🆕 Changed: [Feature] Description...
    🛠️ Fix: [Feature] Description...

@BiliouriV BiliouriV added the advanced Advanced skills are needed for this subject label Nov 10, 2022
@BiliouriV BiliouriV added this to the 2.8.0 milestone Nov 10, 2022
@BiliouriV BiliouriV self-assigned this Nov 10, 2022
@JeromeGalan JeromeGalan merged commit 590280d into rc_2.8.0 Nov 21, 2022
@JeromeGalan JeromeGalan deleted the feat/boot_protection branch November 21, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
advanced Advanced skills are needed for this subject
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants