Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] add critical to Recep_NodeConcerned #415

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

Salem-Tho
Copy link
Member

@Salem-Tho Salem-Tho commented Jan 9, 2023

PR Description section

  • add critical missing to a function call in IRQ Recep_NodeConcerned

Description and dependencies

Please include here a summary of the changes and the related issue. List any dependencies that are required for this change.

Changes

Please choose the relevant options:

  • Bug fix (non-breaking change which fixes an issue)

Related issue(s)

Provide a list of the related issues that will be fixed by this PR.


WARNING: Do not edit the checklist below.


Developer section

  • [Documentation] is up to date with new feature
  • [Tests] are passed OK (non regression, new features & bug fixes)
  • [Code Quality] please check if:
    • Each function has a header (description, inputs, outputs)
    • Code is commented (particularly in hard to understand areas)
    • There are no new warnings that can be corrected
    • Commits policy is respected (constitancy commits, clear commits comments)

QA section

  • [Review] tests for new features have been reviewed
  • [Changelog] is up-to-date with expected tags
    πŸ†• Feature: [Feature] Description...
    πŸ†• Added: [Feature] Description...
    πŸ†• Changed: [Feature] Description...
    πŸ› οΈ Fix: [Feature] Description...

@Salem-Tho Salem-Tho added the type bug Something isn't working label Jan 9, 2023
@Salem-Tho Salem-Tho added this to the 2.9.0 milestone Jan 9, 2023
@Salem-Tho Salem-Tho self-assigned this Jan 9, 2023
@Salem-Tho Salem-Tho linked an issue Jan 9, 2023 that may be closed by this pull request
@JeromeGalan JeromeGalan merged commit 2df2a90 into rc_2.9.0 Jan 12, 2023
@JeromeGalan JeromeGalan deleted the fix/critical_node_concerned branch January 12, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: _CRITICAL for function Recep_NodeConcerned
2 participants