Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does it still support iOS 10 ? #16

Closed
haithngn opened this issue Sep 25, 2018 · 4 comments
Closed

Does it still support iOS 10 ? #16

haithngn opened this issue Sep 25, 2018 · 4 comments

Comments

@haithngn
Copy link

Hi @jianstm ,
I have built Schedule via Carthage (Xcode 9.4.1) then integrate to a project and they said:
Module file's minimum deployment target is ios11.4 v11.4: /Users/hai/Frameworks/Schedule.framework/Modules/Schedule.swiftmodule/x86_64.swiftmodule

I have checked Schedule's targets they are setting from 10.10, could you investigate this ?

@haithngn
Copy link
Author

I have tried on branch 1.x The Carthage said:
Task failed with exit code 65

@luoxiu
Copy link
Owner

luoxiu commented Sep 26, 2018

Hi, @haithngn, sorry for the late reply. I noticed that carthage issue. Schedule was originally created using swift package manager, which doesn't have platforms specified. I think maybe this is the cause of the problem.
I already added framework targets(iOS, macOS, tvOS, watchOS) to Schedule in branch 1.x, but i haven't tested them yet. Will probably release the tested new version this noon. Sorry about the confusion!

@haithngn
Copy link
Author

@jianstm, I solved it.
Could you review this PR #17
Tested on ios 10.0

@luoxiu
Copy link
Owner

luoxiu commented Sep 26, 2018

Hi @haithngn , I just released 1.0.0, with many other changes. I tested it with carthage 0.30.1, it works well now, have a try!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants