Memory Leak

[ApolloZhu]

I noticed this library is leaking RunLoopTask:

and can be reproduced with this trivial macOS example:

class ViewController: NSViewController {
    var task: Task?
    @IBAction func onButtonPress(_ sender: Any) {
        task = Plan.after(Interval(seconds: 2)).do {
            print("Hi")
        }
    }
}

[luoxiu]

Hi, @ApolloZhu , thanks for your feedback. I just pushed a commit and hope it will fix the problem.

[luoxiu]

I'm working on 2.x branch now, and hopefully, I will release 2.0 with this today!

[ApolloZhu]

This fix requires manually invoke task.cancel(). Is that intended behavior?

I suppose not, since then examples in README will cause memory leaks.

[luoxiu]

...
Yes. I thought you were talking about the memory leak caused by an object reference being caught by a closure.
Yes, if a task is no longer being used, you should call its cancel method to release it. I wrote it here). Sorry, my intention is to make it consistent with the timer experience(timer.invalidate()), but I also realized that it seems a bit misleading to users.
I am doing some refactoring now and may redesign this part of the api.

[ApolloZhu]

Thanks for the explanation and sorry for not providing enough context in the previous comment.