Skip to content
This repository has been archived by the owner on Sep 1, 2023. It is now read-only.

Added RegionGrowing api and passed all the test cases, but failed to run it in browser | 增加了RegionGrowing的扩展,也通过了测试用例,但是浏览器里跑不起来 #122

Closed
1 task done
whichones-pink opened this issue Aug 24, 2023 · 2 comments

Comments

@whichones-pink
Copy link

whichones-pink commented Aug 24, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Package Version

extension based on 1.16.0

Current Behavior

When running in browser, all the class we added are not loaded into the PCLCore.
跑在浏览器的时候,暴露出来的一系列类都没加载到PCLCore里面。

image

Expected Behavior

PCLCore should look like the following(pcl.js v1.16.0)
image

Steps To Reproduce

check my code here
diffs
Just build it and use the new-built pcl-core.wasm and pcl.js

Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)

No response

Anything else?

No response

@whichones-pink
Copy link
Author

I made a stupid mistake here that I replaced my node_modules pcl.js and wasm with the new build one. Although my project hot reloaded, the code changes are not detected.
So can I sumbit a PR now?

@luoxuhai
Copy link
Owner

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants