Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper use of Swing and threading #11

Closed
lupino3 opened this issue Feb 25, 2012 · 0 comments
Closed

Proper use of Swing and threading #11

lupino3 opened this issue Feb 25, 2012 · 0 comments

Comments

@lupino3
Copy link
Member

lupino3 commented Feb 25, 2012

The main GUI was developed when the team had basically no idea of how swing interacted with threads. The code should be fixed by using the threading utilities provided by Swing: http://docs.oracle.com/javase/tutorial/uiswing/concurrency/index.html

lupino3 added a commit that referenced this issue May 10, 2017
- visibility fixes;
- use lambdas instead of anonymous inner classes;
- convert some instance members to local variables;

There are some outstanding warnings on synchronization on the non-final
member "cgt", but this will be fixed when fixing #11.
lupino3 added a commit that referenced this issue May 10, 2017
- visibility fixes;
- use lambdas instead of anonymous inner classes;
- convert some instance members to local variables;

There are some outstanding warnings on synchronization on the non-final
member "cgt", but this will be fixed when fixing #11.
lupino3 added a commit that referenced this issue May 13, 2017
- move the core CPU execution to a SwingWorker;
- use the event dispatch thread for UI updates.

There is very crude rate limiting code implemented, but a better
solution should be implemented before merging this code.

Fixes #11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant