Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cycles UI for hailstoneenglish.s #134

Closed
lupino3 opened this issue Aug 23, 2016 · 4 comments
Closed

Fix cycles UI for hailstoneenglish.s #134

lupino3 opened this issue Aug 23, 2016 · 4 comments
Labels
component:core component:swing-ui in progress priority:1 type:bug

Comments

@lupino3
Copy link
Member

lupino3 commented Aug 23, 2016 •
edited

Running the hailstoneenglish.s test, the Cycles window becomes garbled after some time.

This is probably related to the warnings seen during tests:

[junit] Aug 23, 2016 1:26:34 PM org.edumips64.ui.common.CycleElement addState
[junit] SEVERE: State WAW is not allowed after state RAW
[junit] Aug 23, 2016 1:26:34 PM org.edumips64.ui.common.CycleElement addState
[junit] SEVERE: State WAW is not allowed after state RAW
[junit] Aug 23, 2016 1:26:34 PM org.edumips64.ui.common.CycleElement addState
[junit] SEVERE: State WAW is not allowed after state RAW
[junit] Aug 23, 2016 1:26:35 PM org.edumips64.ui.common.CycleElement addState
[junit] SEVERE: State WB is not allowed after state IF
[junit] Aug 23, 2016 1:26:35 PM org.edumips64.ui.common.CycleElement addState
[junit] SEVERE: State ID is not allowed after state WB
[junit] Aug 23, 2016 1:26:35 PM org.edumips64.ui.common.CycleElement addState
[junit] SEVERE: State WB is not allowed after state IF
[junit] Aug 23, 2016 1:26:35 PM org.edumips64.ui.common.CycleElement addState
[junit] SEVERE: State ID is not allowed after state WB
[junit] Aug 23, 2016 1:26:35 PM org.edumips64.ui.common.CycleElement addState
[junit] SEVERE: State WB is not allowed after state IF
[junit] Aug 23, 2016 1:26:35 PM org.edumips64.ui.common.CycleElement addState
[junit] SEVERE: State ID is not allowed after state WB
[junit] Aug 23, 2016 1:26:35 PM org.edumips64.ui.common.CycleElement addState
[junit] SEVERE: State WB is not allowed after state IF
[junit] Aug 23, 2016 1:26:35 PM org.edumips64.ui.common.CycleElement addState
[junit] SEVERE: State ID is not allowed after state WB
[junit] Aug 23, 2016 1:26:35 PM org.edumips64.ui.common.CycleElement addState
[junit] SEVERE: State WB is not allowed after state IF
[junit] Aug 23, 2016 1:26:35 PM org.edumips64.ui.common.CycleElement addState
[junit] SEVERE: State ID is not allowed after state WB
lupino3 added a commit that referenced this issue Aug 23, 2016
@lupino3
Do not draw the registers window if the sync is disabled
ea3e443 
Fixes #133, and almost #132, if it were not for #134.
@lupino3 lupino3 mentioned this issue Aug 23, 2016
Closed
@lupino3
Copy link
Member Author

lupino3 commented Aug 24, 2016

It seems that there are 2 classes of errors here.

The first one is about WAW after RAW, which is due to one of the FPU tests. I think that one is legit and I will verify it.

All the other errors seem to not appear always: I ran the tests twice and they appeared only in one run.

@lupino3
Copy link
Member Author

lupino3 commented Apr 10, 2017

The error about WAW after RAW is fixed. I am working on #139, which might be related.

@lupino3
Copy link
Member Author

lupino3 commented May 3, 2017

The UI becoming garbled is not related to #139 or to any of those error logs. I have a fix for #139 which I am about to push, but the UI still becomes garbage after some time; in my test, this happens around cycle 4000.

@lupino3
Copy link
Member Author

lupino3 commented May 21, 2017

It happens precisely at cycle 4370. The interesting thing is that at cycle 4369 instruction in cycle 1 is shown again. I reproduced this in a test build that also prints the cycle number to the left of the instruction:

wrong

Looks like some sort of overflow..

lupino3 added a commit that referenced this issue Jul 27, 2018
@lupino3
Narrow GUICycles painting using clip regions
943490b 
This makes GUICycles slightly more efficient by avoiding to paint
rows that don't need to be painted.

But, more importantly, this fixes #134.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:core component:swing-ui in progress priority:1 type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lupino3