Fix problem with disabled tray icon #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steps to reproduce bug: 1.) reset settings to default 2.) export configuration 3.) set disabled tray icon 4.) import default configuration (with enabled tray icon) Result: tray icon still disabled Expected result: enabled try icon Problem was in the fact, that showTrayIconChanged was executed only when user has clicked on that checkbox. Now it run even while importing config file.
|
typo in commit: s/try/tray/ |
|
Travis again failed because of repo errors. It's not my fault. |
|
Wuzzup, @lupoDharkael? It's very trivial patch! |
|
Thanks for the contribution! |
vt-alt
pushed a commit
to altlinux/specs
that referenced
this pull request
Jun 3, 2019
- Build from new commit. - Fix problem with disabled tray icon (Closes: #36299). + (flameshot-org/flameshot#495) - New try of fixing icon in autostarted program (Closes: #36134). - E2K: strip UTF-8 BOM for lcc < 1.24 (thx to mike@). - Minor spec cleanup (thx to mike@).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce bug:
1.) reset settings to default
2.) export configuration
3.) set disabled tray icon
4.) import default configuration (with enabled tray icon)
Result: tray icon still disabled
Expected result: enabled try icon
Problem was in the fact, that showTrayIconChanged was executed
only when user has clicked on that checkbox. Now it run even
while importing config file.