Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate detection is too strict #10

Closed
jlnr opened this issue Jul 18, 2016 · 1 comment
Closed

Duplicate detection is too strict #10

jlnr opened this issue Jul 18, 2016 · 1 comment
Labels
bug

Comments

@jlnr
Copy link
Member

jlnr commented Jul 18, 2016

Many movies use a proper apostrophe (’) in one language and ASCII ' in another, leading to this mess:

img_8237

This should be fixed by ignoring punctuation in almost_equal (in Database/Rakefile). Maybe "The" should be ignored here, too? I don't think adding or removing a "The" counts as a translation.
@jlnr jlnr added the bug label Jul 18, 2016
@jlnr jlnr closed this as completed in 95a4e08 Aug 9, 2016
@jlnr
Copy link
Member Author

jlnr commented Aug 9, 2016 •
edited

Didn't bother adding /$The / to the gsub call for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jlnr