Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where did the examples go? #684

Closed
ijsnow opened this issue Sep 18, 2023 · 3 comments
Closed

Where did the examples go? #684

ijsnow opened this issue Sep 18, 2023 · 3 comments
Labels

Comments

@ijsnow
Copy link

ijsnow commented Sep 18, 2023

Describe the bug

The links to the two examples here result in a 404.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://github.com/luraproject/lura/blob/master/docs/README.md#examples
  2. Click a link to the examples.

Expected behavior
Links take you to examples.

Logs
N/a

Additional context
I've searched for directories in the repo with examples in the path and didn't find anything.

@kpacha
Copy link
Member

kpacha commented Sep 18, 2023

Thanks for bringing it to our attention!

Maintaining all the examples was too costly so, initially we remove them from the repo and, latter, we even stop maintaining the repo https://github.com/devopsfaith/krakend-examples. We though that the best and most detailed example was the krakend CE repository (where all the potential of the framework is used).

I'll keep the issue open until we remove all the dead links

@ijsnow
Copy link
Author

ijsnow commented Sep 18, 2023

Ah fair enough! Good old fashion code search for references of functions you want to use should do the trick.

@taik0 taik0 closed this as completed Sep 28, 2023
Copy link

This issue was marked as resolved a long time ago and now has been automatically locked as there has not been any recent activity after it. You can still open a new issue and reference this link.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants