Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge data from incomplete responses #80

Closed
kpacha opened this issue Jan 26, 2018 · 1 comment · Fixed by #84
Closed

Merge data from incomplete responses #80

kpacha opened this issue Jan 26, 2018 · 1 comment · Fixed by #84
Labels
locked

Comments

@kpacha
Copy link
Member

kpacha commented Jan 26, 2018

The current combiner implementation does not include data from incomplete responses in the final merge due the condition in https://github.com/devopsfaith/krakend/blob/master/proxy/merging.go#L85
@dhontecillas dhontecillas mentioned this issue Jan 31, 2018
Merged
@kpacha kpacha closed this as completed in #84 Feb 1, 2018
kpacha added a commit that referenced this issue Feb 1, 2018
@kpacha
Merge pull request #84 from dhontecillas/merge_incomplete_responses_data
eb23565 
Fix #80: Merge incomplete responses data
@github-actions
Copy link

This issue was marked as resolved a long time ago and now has been automatically locked as there has not been any recent activity after it. You can still open a new issue and reference this link.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #80: Merge incomplete responses data
1 participant
@kpacha