exporting symbols

[jubalh]

I saw that both Fedora and openSUSE export some more symbols. Maybe this is something that should be upstreamed?

Fedora symbols:
https://src.fedoraproject.org/rpms/unixODBC/blob/master/f/export-symbols.patch
openSUSE exports:
https://build.opensuse.org/package/view_file/server:database/unixODBC/unixODBC-2.3.1-libodbcinst-exports.patch?expand=1

[lurcher]

The Fedora addition looks like it is worth adding, but I would like to know what problem the openSUSE patch fixes, the base its applied to is 7 years old and I have not had a report of the code needing that from anywhere else.

[jubalh]

It's an old bug indeed: https://bugzilla.suse.com/show_bug.cgi?id=131175
Seems that unixODBC-gui-qt needed it to work properly.
However we don't ship the GUI anymore, so it is not really relevant to us.

Thought it best to be reported here anyways.

[jubalh]

BTW Fedora has another patch here: https://src.fedoraproject.org/rpms/unixODBC/blob/master/f/keep-typedefs.patch

[lurcher]

Ok, I am in agreement that leaving it here is fine, if it does come back we can deal with it then.

The second Fedora patch, I am thinking to ignore. Microsoft have removed those defs from ODBC, so if the absence causes a problem building against unixODBC, the same problem will occur latter on in a Windows build. If there are still drivers out there that fail because of that, I would suggest that they add the typedefs to their own code as its their choice.

[praiskup]

Thanks a lot for making those symbols upstream. I guess closing this now is fine.
edit: FWIW, Fedora PR dropping the downstream patch: https://src.fedoraproject.org/rpms/unixODBC/pull-request/4