Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make target to install miscellaneous non-binary files #49

Closed
JamiKettunen opened this issue Dec 19, 2022 · 2 comments
Closed

Make target to install miscellaneous non-binary files #49

JamiKettunen opened this issue Dec 19, 2022 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@JamiKettunen
Copy link

JamiKettunen commented Dec 19, 2022

A separate e.g. installmisc target for non-binary files (which install depends on) would be nice so it can be called separately from e.g. the Void package build template where (cross-)building Go packages is handled with a build-style and a corresponding environment, and for non-binaries just this would be then needed:

post_install() {
    make PREFIX=/usr DESTDIR=${DESTDIR} installmisc
}

I previously sent https://lists.sr.ht/~craftyguy/superd/patches/36158 which the Void package handles in a similar way.

Copied mostly from #46 as I didn't get any particular feedback to this suggestion yet.

@JamiKettunen
Copy link
Author

I suppose for now it's a bit redundant (at least in case of Void) as the same can be accomplished pretty easily also with:

post_install() {
    vcompletion scripts/completion/bash bash
    vcompletion scripts/completion/zsh zsh
}

Just thinking in terms of future additions it might become more complicated to keep maintaining.

@Elara6331 Elara6331 added enhancement New feature or request good first issue Good for newcomers labels Dec 22, 2022
@Elara6331 Elara6331 added this to the v0.0.6 milestone Dec 28, 2022
@Elara6331
Copy link
Member

Done in 8a1d0f4, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants