-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Refactor supernova module to avoid needless pass-by-value #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0d8f67a
to
1935059
Compare
porcuquine
previously approved these changes
Aug 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good once CI passes. Consider merging #23 first then applying changes there for simplicity if this is still incomplete.
1935059
to
012c58c
Compare
porcuquine
previously approved these changes
Aug 27, 2023
5ef7ea2
to
a25bc5b
Compare
porcuquine
previously approved these changes
Aug 28, 2023
a25bc5b
to
5785b4b
Compare
- Modified `SuperNovaAugmentedCircuitParams` to be passed by reference in `test_recursive_circuit_with` function and associated instances in `test.rs`. - Updated `SuperNovaAugmentedCircuit::new` method to match changes in the `test_recursive_circuit_with` function. - Revamped arguments handling in `synthesize_non_base_case` and `synthesize` functions in `circuit.rs`, changing from owned types to references to reduce unnecessary cloning. - Altered function body to accommodate the changes for referenced values in `circuit.rs`.
5785b4b
to
caa1255
Compare
porcuquine
approved these changes
Aug 28, 2023
huitseeker
added a commit
that referenced
this pull request
Dec 17, 2023
This backports the following Arecibo PRs: - #2 - #3 - #10 - #16 - #23 - #30 - #28 - #41 - #45 - #50 - #56 - #51 - #72 - #92 - #95 - #97 - #101 - #110 - #106 - #112 - #114 - #119 - #120 - #127 - #123 - #131 - #174 - #175 - #182 Co-authored-by: WYATT <wyattbenno@gmail.com> Co-authored-by: Hanting Zhang <hantingz@usc.edu> Co-authored-by: Ming <hero78119@gmail.com> Co-authored-by: porcuquine <porcuquine@users.noreply.github.com> Co-authored-by: Samuel Burnham <45365069+samuelburnham@users.noreply.github.com> Co-authored-by: Matej Penciak <96667244+mpenciak@users.noreply.github.com> Co-authored-by: Adrian Hamelink <adrian.hamelink@gmail.com>
huitseeker
added a commit
to argumentcomputer/Nova
that referenced
this pull request
Dec 17, 2023
This implements [Supernova](https://eprint.iacr.org/2022/1758), allowing: - a 'pay-as-you-go' cost structure for folding operations, through the SuperNova folding scheme, - a final SNARK that efficiently compresses an instance of this folded proof, through batching techniques. References: - the [blog post](https://blog.lurk-lang.org/posts/arecibo-supernova/#technical-release-note-supernova-protocol-integration-into-nova) goes into our construction, and links to two more specialized notes on [the `CompressedSNARK` for Supernova](https://hackmd.io/@adr1anh/BJw1g0aBT) along with our variant of the [public input padding issue](https://hackmd.io/@adr1anh/Sy08YaVBa). - the Readme at `src/supernova/Readme.md` This backports the following Arecibo PRs: - argumentcomputer/arecibo#2 - argumentcomputer/arecibo#3 - argumentcomputer/arecibo#10 - argumentcomputer/arecibo#16 - argumentcomputer/arecibo#23 - argumentcomputer/arecibo#30 - argumentcomputer/arecibo#28 - argumentcomputer/arecibo#41 - argumentcomputer/arecibo#45 - argumentcomputer/arecibo#50 - argumentcomputer/arecibo#56 - argumentcomputer/arecibo#51 - argumentcomputer/arecibo#72 - argumentcomputer/arecibo#92 - argumentcomputer/arecibo#95 - argumentcomputer/arecibo#97 - argumentcomputer/arecibo#101 - argumentcomputer/arecibo#110 - argumentcomputer/arecibo#106 - argumentcomputer/arecibo#112 - argumentcomputer/arecibo#114 - argumentcomputer/arecibo#119 - argumentcomputer/arecibo#120 - argumentcomputer/arecibo#127 - argumentcomputer/arecibo#123 - argumentcomputer/arecibo#131 - argumentcomputer/arecibo#174 - argumentcomputer/arecibo#175 - argumentcomputer/arecibo#182 Co-authored-by: WYATT <wyattbenno@gmail.com> Co-authored-by: Hanting Zhang <hantingz@usc.edu> Co-authored-by: Ming <hero78119@gmail.com> Co-authored-by: porcuquine <porcuquine@users.noreply.github.com> Co-authored-by: Samuel Burnham <45365069+samuelburnham@users.noreply.github.com> Co-authored-by: Matej Penciak <96667244+mpenciak@users.noreply.github.com> Co-authored-by: Adrian Hamelink <adrian.hamelink@gmail.com>
huitseeker
added a commit
to argumentcomputer/Nova
that referenced
this pull request
Dec 18, 2023
This implements [Supernova](https://eprint.iacr.org/2022/1758), allowing: - a 'pay-as-you-go' cost structure for folding operations, through the SuperNova folding scheme, - a final SNARK that efficiently compresses an instance of this folded proof, through batching techniques. References: - the [blog post](https://blog.lurk-lang.org/posts/arecibo-supernova/#technical-release-note-supernova-protocol-integration-into-nova) goes into our construction, and links to two more specialized notes on [the `CompressedSNARK` for Supernova](https://hackmd.io/@adr1anh/BJw1g0aBT) along with our variant of the [public input padding issue](https://hackmd.io/@adr1anh/Sy08YaVBa). - the Readme at `src/supernova/Readme.md` This backports the following Arecibo PRs: - argumentcomputer/arecibo#2 - argumentcomputer/arecibo#3 - argumentcomputer/arecibo#10 - argumentcomputer/arecibo#16 - argumentcomputer/arecibo#23 - argumentcomputer/arecibo#30 - argumentcomputer/arecibo#28 - argumentcomputer/arecibo#41 - argumentcomputer/arecibo#45 - argumentcomputer/arecibo#50 - argumentcomputer/arecibo#56 - argumentcomputer/arecibo#51 - argumentcomputer/arecibo#72 - argumentcomputer/arecibo#92 - argumentcomputer/arecibo#95 - argumentcomputer/arecibo#97 - argumentcomputer/arecibo#101 - argumentcomputer/arecibo#110 - argumentcomputer/arecibo#106 - argumentcomputer/arecibo#112 - argumentcomputer/arecibo#114 - argumentcomputer/arecibo#119 - argumentcomputer/arecibo#120 - argumentcomputer/arecibo#127 - argumentcomputer/arecibo#123 - argumentcomputer/arecibo#131 - argumentcomputer/arecibo#174 - argumentcomputer/arecibo#175 - argumentcomputer/arecibo#182 Co-authored-by: WYATT <wyattbenno@gmail.com> Co-authored-by: Hanting Zhang <hantingz@usc.edu> Co-authored-by: Ming <hero78119@gmail.com> Co-authored-by: porcuquine <porcuquine@users.noreply.github.com> Co-authored-by: Samuel Burnham <45365069+samuelburnham@users.noreply.github.com> Co-authored-by: Matej Penciak <96667244+mpenciak@users.noreply.github.com> Co-authored-by: Adrian Hamelink <adrian.hamelink@gmail.com>
huitseeker
added a commit
to argumentcomputer/Nova
that referenced
this pull request
Jan 3, 2024
This implements [Supernova](https://eprint.iacr.org/2022/1758), allowing: - a 'pay-as-you-go' cost structure for folding operations, through the SuperNova folding scheme, - a final SNARK that efficiently compresses an instance of this folded proof, through batching techniques. References: - the [blog post](https://blog.lurk-lang.org/posts/arecibo-supernova/#technical-release-note-supernova-protocol-integration-into-nova) goes into our construction, and links to two more specialized notes on [the `CompressedSNARK` for Supernova](https://hackmd.io/@adr1anh/BJw1g0aBT) along with our variant of the [public input padding issue](https://hackmd.io/@adr1anh/Sy08YaVBa). - the Readme at `src/supernova/Readme.md` This backports the following Arecibo PRs: - argumentcomputer/arecibo#2 - argumentcomputer/arecibo#3 - argumentcomputer/arecibo#10 - argumentcomputer/arecibo#16 - argumentcomputer/arecibo#23 - argumentcomputer/arecibo#30 - argumentcomputer/arecibo#28 - argumentcomputer/arecibo#41 - argumentcomputer/arecibo#45 - argumentcomputer/arecibo#50 - argumentcomputer/arecibo#56 - argumentcomputer/arecibo#51 - argumentcomputer/arecibo#72 - argumentcomputer/arecibo#92 - argumentcomputer/arecibo#95 - argumentcomputer/arecibo#97 - argumentcomputer/arecibo#101 - argumentcomputer/arecibo#110 - argumentcomputer/arecibo#106 - argumentcomputer/arecibo#112 - argumentcomputer/arecibo#114 - argumentcomputer/arecibo#119 - argumentcomputer/arecibo#120 - argumentcomputer/arecibo#127 - argumentcomputer/arecibo#123 - argumentcomputer/arecibo#131 - argumentcomputer/arecibo#174 - argumentcomputer/arecibo#175 - argumentcomputer/arecibo#182 Co-authored-by: WYATT <wyattbenno@gmail.com> Co-authored-by: Hanting Zhang <hantingz@usc.edu> Co-authored-by: Ming <hero78119@gmail.com> Co-authored-by: porcuquine <porcuquine@users.noreply.github.com> Co-authored-by: Samuel Burnham <45365069+samuelburnham@users.noreply.github.com> Co-authored-by: Matej Penciak <96667244+mpenciak@users.noreply.github.com> Co-authored-by: Adrian Hamelink <adrian.hamelink@gmail.com>
huitseeker
added a commit
to argumentcomputer/Nova
that referenced
this pull request
Jan 4, 2024
This implements [Supernova](https://eprint.iacr.org/2022/1758), allowing: - a 'pay-as-you-go' cost structure for folding operations, through the SuperNova folding scheme, - a final SNARK that efficiently compresses an instance of this folded proof, through batching techniques. References: - the [blog post](https://blog.lurk-lang.org/posts/arecibo-supernova/#technical-release-note-supernova-protocol-integration-into-nova) goes into our construction, and links to two more specialized notes on [the `CompressedSNARK` for Supernova](https://hackmd.io/@adr1anh/BJw1g0aBT) along with our variant of the [public input padding issue](https://hackmd.io/@adr1anh/Sy08YaVBa). - the Readme at `src/supernova/Readme.md` This backports the following Arecibo PRs: - argumentcomputer/arecibo#2 - argumentcomputer/arecibo#3 - argumentcomputer/arecibo#10 - argumentcomputer/arecibo#16 - argumentcomputer/arecibo#23 - argumentcomputer/arecibo#30 - argumentcomputer/arecibo#28 - argumentcomputer/arecibo#41 - argumentcomputer/arecibo#45 - argumentcomputer/arecibo#50 - argumentcomputer/arecibo#56 - argumentcomputer/arecibo#51 - argumentcomputer/arecibo#72 - argumentcomputer/arecibo#92 - argumentcomputer/arecibo#95 - argumentcomputer/arecibo#97 - argumentcomputer/arecibo#101 - argumentcomputer/arecibo#110 - argumentcomputer/arecibo#106 - argumentcomputer/arecibo#112 - argumentcomputer/arecibo#114 - argumentcomputer/arecibo#119 - argumentcomputer/arecibo#120 - argumentcomputer/arecibo#127 - argumentcomputer/arecibo#123 - argumentcomputer/arecibo#131 - argumentcomputer/arecibo#174 - argumentcomputer/arecibo#175 - argumentcomputer/arecibo#182 Co-authored-by: WYATT <wyattbenno@gmail.com> Co-authored-by: Hanting Zhang <hantingz@usc.edu> Co-authored-by: Ming <hero78119@gmail.com> Co-authored-by: porcuquine <porcuquine@users.noreply.github.com> Co-authored-by: Samuel Burnham <45365069+samuelburnham@users.noreply.github.com> Co-authored-by: Matej Penciak <96667244+mpenciak@users.noreply.github.com> Co-authored-by: Adrian Hamelink <adrian.hamelink@gmail.com>
huitseeker
added a commit
to argumentcomputer/Nova
that referenced
this pull request
Jan 16, 2024
This implements [Supernova](https://eprint.iacr.org/2022/1758), allowing: - a 'pay-as-you-go' cost structure for folding operations, through the SuperNova folding scheme, - a final SNARK that efficiently compresses an instance of this folded proof, through batching techniques. References: - the [blog post](https://blog.lurk-lang.org/posts/arecibo-supernova/#technical-release-note-supernova-protocol-integration-into-nova) goes into our construction, and links to two more specialized notes on [the `CompressedSNARK` for Supernova](https://hackmd.io/@adr1anh/BJw1g0aBT) along with our variant of the [public input padding issue](https://hackmd.io/@adr1anh/Sy08YaVBa). - the Readme at `src/supernova/Readme.md` This backports the following Arecibo PRs: - argumentcomputer/arecibo#2 - argumentcomputer/arecibo#3 - argumentcomputer/arecibo#10 - argumentcomputer/arecibo#16 - argumentcomputer/arecibo#23 - argumentcomputer/arecibo#30 - argumentcomputer/arecibo#28 - argumentcomputer/arecibo#41 - argumentcomputer/arecibo#45 - argumentcomputer/arecibo#50 - argumentcomputer/arecibo#56 - argumentcomputer/arecibo#51 - argumentcomputer/arecibo#72 - argumentcomputer/arecibo#92 - argumentcomputer/arecibo#95 - argumentcomputer/arecibo#97 - argumentcomputer/arecibo#101 - argumentcomputer/arecibo#110 - argumentcomputer/arecibo#106 - argumentcomputer/arecibo#112 - argumentcomputer/arecibo#114 - argumentcomputer/arecibo#119 - argumentcomputer/arecibo#120 - argumentcomputer/arecibo#127 - argumentcomputer/arecibo#123 - argumentcomputer/arecibo#131 - argumentcomputer/arecibo#174 - argumentcomputer/arecibo#175 - argumentcomputer/arecibo#182 Co-authored-by: WYATT <wyattbenno@gmail.com> Co-authored-by: Hanting Zhang <hantingz@usc.edu> Co-authored-by: Ming <hero78119@gmail.com> Co-authored-by: porcuquine <porcuquine@users.noreply.github.com> Co-authored-by: Samuel Burnham <45365069+samuelburnham@users.noreply.github.com> Co-authored-by: Matej Penciak <96667244+mpenciak@users.noreply.github.com> Co-authored-by: Adrian Hamelink <adrian.hamelink@gmail.com>
huitseeker
added a commit
to argumentcomputer/Nova
that referenced
this pull request
Jan 25, 2024
This implements [Supernova](https://eprint.iacr.org/2022/1758), allowing: - a 'pay-as-you-go' cost structure for folding operations, through the SuperNova folding scheme, - a final SNARK that efficiently compresses an instance of this folded proof, through batching techniques. References: - the [blog post](https://blog.lurk-lang.org/posts/arecibo-supernova/#technical-release-note-supernova-protocol-integration-into-nova) goes into our construction, and links to two more specialized notes on [the `CompressedSNARK` for Supernova](https://hackmd.io/@adr1anh/BJw1g0aBT) along with our variant of the [public input padding issue](https://hackmd.io/@adr1anh/Sy08YaVBa). - the Readme at `src/supernova/Readme.md` This backports the following Arecibo PRs: - argumentcomputer/arecibo#2 - argumentcomputer/arecibo#3 - argumentcomputer/arecibo#10 - argumentcomputer/arecibo#16 - argumentcomputer/arecibo#23 - argumentcomputer/arecibo#30 - argumentcomputer/arecibo#28 - argumentcomputer/arecibo#41 - argumentcomputer/arecibo#45 - argumentcomputer/arecibo#50 - argumentcomputer/arecibo#56 - argumentcomputer/arecibo#51 - argumentcomputer/arecibo#72 - argumentcomputer/arecibo#92 - argumentcomputer/arecibo#95 - argumentcomputer/arecibo#97 - argumentcomputer/arecibo#101 - argumentcomputer/arecibo#110 - argumentcomputer/arecibo#106 - argumentcomputer/arecibo#112 - argumentcomputer/arecibo#114 - argumentcomputer/arecibo#119 - argumentcomputer/arecibo#120 - argumentcomputer/arecibo#127 - argumentcomputer/arecibo#123 - argumentcomputer/arecibo#131 - argumentcomputer/arecibo#174 - argumentcomputer/arecibo#175 - argumentcomputer/arecibo#182 Co-authored-by: WYATT <wyattbenno@gmail.com> Co-authored-by: Hanting Zhang <hantingz@usc.edu> Co-authored-by: Ming <hero78119@gmail.com> Co-authored-by: porcuquine <porcuquine@users.noreply.github.com> Co-authored-by: Samuel Burnham <45365069+samuelburnham@users.noreply.github.com> Co-authored-by: Matej Penciak <96667244+mpenciak@users.noreply.github.com> Co-authored-by: Adrian Hamelink <adrian.hamelink@gmail.com>
huitseeker
added a commit
to argumentcomputer/Nova
that referenced
this pull request
Jan 25, 2024
This implements [Supernova](https://eprint.iacr.org/2022/1758), allowing: - a 'pay-as-you-go' cost structure for folding operations, through the SuperNova folding scheme, - a final SNARK that efficiently compresses an instance of this folded proof, through batching techniques. References: - the [blog post](https://blog.lurk-lang.org/posts/arecibo-supernova/#technical-release-note-supernova-protocol-integration-into-nova) goes into our construction, and links to two more specialized notes on [the `CompressedSNARK` for Supernova](https://hackmd.io/@adr1anh/BJw1g0aBT) along with our variant of the [public input padding issue](https://hackmd.io/@adr1anh/Sy08YaVBa). - the Readme at `src/supernova/Readme.md` This backports the following Arecibo PRs: - argumentcomputer/arecibo#2 - argumentcomputer/arecibo#3 - argumentcomputer/arecibo#10 - argumentcomputer/arecibo#16 - argumentcomputer/arecibo#23 - argumentcomputer/arecibo#30 - argumentcomputer/arecibo#28 - argumentcomputer/arecibo#41 - argumentcomputer/arecibo#45 - argumentcomputer/arecibo#50 - argumentcomputer/arecibo#56 - argumentcomputer/arecibo#51 - argumentcomputer/arecibo#72 - argumentcomputer/arecibo#92 - argumentcomputer/arecibo#95 - argumentcomputer/arecibo#97 - argumentcomputer/arecibo#101 - argumentcomputer/arecibo#110 - argumentcomputer/arecibo#106 - argumentcomputer/arecibo#112 - argumentcomputer/arecibo#114 - argumentcomputer/arecibo#119 - argumentcomputer/arecibo#120 - argumentcomputer/arecibo#127 - argumentcomputer/arecibo#123 - argumentcomputer/arecibo#131 - argumentcomputer/arecibo#174 - argumentcomputer/arecibo#175 - argumentcomputer/arecibo#182 Co-authored-by: WYATT <wyattbenno@gmail.com> Co-authored-by: Hanting Zhang <hantingz@usc.edu> Co-authored-by: Ming <hero78119@gmail.com> Co-authored-by: porcuquine <porcuquine@users.noreply.github.com> Co-authored-by: Samuel Burnham <45365069+samuelburnham@users.noreply.github.com> Co-authored-by: Matej Penciak <96667244+mpenciak@users.noreply.github.com> Co-authored-by: Adrian Hamelink <adrian.hamelink@gmail.com>
huitseeker
added a commit
to argumentcomputer/Nova
that referenced
this pull request
Jan 31, 2024
This implements [Supernova](https://eprint.iacr.org/2022/1758), allowing: - a 'pay-as-you-go' cost structure for folding operations, through the SuperNova folding scheme, - a final SNARK that efficiently compresses an instance of this folded proof, through batching techniques. References: - the [blog post](https://blog.lurk-lang.org/posts/arecibo-supernova/#technical-release-note-supernova-protocol-integration-into-nova) goes into our construction, and links to two more specialized notes on [the `CompressedSNARK` for Supernova](https://hackmd.io/@adr1anh/BJw1g0aBT) along with our variant of the [public input padding issue](https://hackmd.io/@adr1anh/Sy08YaVBa). - the Readme at `src/supernova/Readme.md` This backports the following Arecibo PRs: - argumentcomputer/arecibo#2 - argumentcomputer/arecibo#3 - argumentcomputer/arecibo#10 - argumentcomputer/arecibo#16 - argumentcomputer/arecibo#23 - argumentcomputer/arecibo#30 - argumentcomputer/arecibo#28 - argumentcomputer/arecibo#41 - argumentcomputer/arecibo#45 - argumentcomputer/arecibo#50 - argumentcomputer/arecibo#56 - argumentcomputer/arecibo#51 - argumentcomputer/arecibo#72 - argumentcomputer/arecibo#92 - argumentcomputer/arecibo#95 - argumentcomputer/arecibo#97 - argumentcomputer/arecibo#101 - argumentcomputer/arecibo#110 - argumentcomputer/arecibo#106 - argumentcomputer/arecibo#112 - argumentcomputer/arecibo#114 - argumentcomputer/arecibo#119 - argumentcomputer/arecibo#120 - argumentcomputer/arecibo#127 - argumentcomputer/arecibo#123 - argumentcomputer/arecibo#131 - argumentcomputer/arecibo#174 - argumentcomputer/arecibo#175 - argumentcomputer/arecibo#182 Co-authored-by: WYATT <wyattbenno@gmail.com> Co-authored-by: Hanting Zhang <hantingz@usc.edu> Co-authored-by: Ming <hero78119@gmail.com> Co-authored-by: porcuquine <porcuquine@users.noreply.github.com> Co-authored-by: Samuel Burnham <45365069+samuelburnham@users.noreply.github.com> Co-authored-by: Matej Penciak <96667244+mpenciak@users.noreply.github.com> Co-authored-by: Adrian Hamelink <adrian.hamelink@gmail.com>
huitseeker
added a commit
to argumentcomputer/Nova
that referenced
this pull request
Feb 21, 2024
This implements [Supernova](https://eprint.iacr.org/2022/1758), allowing: - a 'pay-as-you-go' cost structure for folding operations, through the SuperNova folding scheme, - a final SNARK that efficiently compresses an instance of this folded proof, through batching techniques. References: - the [blog post](https://blog.lurk-lang.org/posts/arecibo-supernova/#technical-release-note-supernova-protocol-integration-into-nova) goes into our construction, and links to two more specialized notes on [the `CompressedSNARK` for Supernova](https://hackmd.io/@adr1anh/BJw1g0aBT) along with our variant of the [public input padding issue](https://hackmd.io/@adr1anh/Sy08YaVBa). - the Readme at `src/supernova/Readme.md` This backports the following Arecibo PRs: - argumentcomputer/arecibo#2 - argumentcomputer/arecibo#3 - argumentcomputer/arecibo#10 - argumentcomputer/arecibo#16 - argumentcomputer/arecibo#23 - argumentcomputer/arecibo#30 - argumentcomputer/arecibo#28 - argumentcomputer/arecibo#41 - argumentcomputer/arecibo#45 - argumentcomputer/arecibo#50 - argumentcomputer/arecibo#56 - argumentcomputer/arecibo#51 - argumentcomputer/arecibo#72 - argumentcomputer/arecibo#92 - argumentcomputer/arecibo#95 - argumentcomputer/arecibo#97 - argumentcomputer/arecibo#101 - argumentcomputer/arecibo#110 - argumentcomputer/arecibo#106 - argumentcomputer/arecibo#112 - argumentcomputer/arecibo#114 - argumentcomputer/arecibo#119 - argumentcomputer/arecibo#120 - argumentcomputer/arecibo#127 - argumentcomputer/arecibo#123 - argumentcomputer/arecibo#131 - argumentcomputer/arecibo#174 - argumentcomputer/arecibo#175 - argumentcomputer/arecibo#182 Co-authored-by: WYATT <wyattbenno@gmail.com> Co-authored-by: Hanting Zhang <hantingz@usc.edu> Co-authored-by: Ming <hero78119@gmail.com> Co-authored-by: porcuquine <porcuquine@users.noreply.github.com> Co-authored-by: Samuel Burnham <45365069+samuelburnham@users.noreply.github.com> Co-authored-by: Matej Penciak <96667244+mpenciak@users.noreply.github.com> Co-authored-by: Adrian Hamelink <adrian.hamelink@gmail.com>
huitseeker
added a commit
to argumentcomputer/Nova
that referenced
this pull request
Mar 7, 2024
This implements [Supernova](https://eprint.iacr.org/2022/1758), allowing: - a 'pay-as-you-go' cost structure for folding operations, through the SuperNova folding scheme, - a final SNARK that efficiently compresses an instance of this folded proof, through batching techniques. References: - the [blog post](https://blog.lurk-lang.org/posts/arecibo-supernova/#technical-release-note-supernova-protocol-integration-into-nova) goes into our construction, and links to two more specialized notes on [the `CompressedSNARK` for Supernova](https://hackmd.io/@adr1anh/BJw1g0aBT) along with our variant of the [public input padding issue](https://hackmd.io/@adr1anh/Sy08YaVBa). - the Readme at `src/supernova/Readme.md` This backports the following Arecibo PRs: - argumentcomputer/arecibo#2 - argumentcomputer/arecibo#3 - argumentcomputer/arecibo#10 - argumentcomputer/arecibo#16 - argumentcomputer/arecibo#23 - argumentcomputer/arecibo#30 - argumentcomputer/arecibo#28 - argumentcomputer/arecibo#41 - argumentcomputer/arecibo#45 - argumentcomputer/arecibo#50 - argumentcomputer/arecibo#56 - argumentcomputer/arecibo#51 - argumentcomputer/arecibo#72 - argumentcomputer/arecibo#92 - argumentcomputer/arecibo#95 - argumentcomputer/arecibo#97 - argumentcomputer/arecibo#101 - argumentcomputer/arecibo#110 - argumentcomputer/arecibo#106 - argumentcomputer/arecibo#112 - argumentcomputer/arecibo#114 - argumentcomputer/arecibo#119 - argumentcomputer/arecibo#120 - argumentcomputer/arecibo#127 - argumentcomputer/arecibo#123 - argumentcomputer/arecibo#131 - argumentcomputer/arecibo#174 - argumentcomputer/arecibo#175 - argumentcomputer/arecibo#182 Co-authored-by: WYATT <wyattbenno@gmail.com> Co-authored-by: Hanting Zhang <hantingz@usc.edu> Co-authored-by: Ming <hero78119@gmail.com> Co-authored-by: porcuquine <porcuquine@users.noreply.github.com> Co-authored-by: Samuel Burnham <45365069+samuelburnham@users.noreply.github.com> Co-authored-by: Matej Penciak <96667244+mpenciak@users.noreply.github.com> Co-authored-by: Adrian Hamelink <adrian.hamelink@gmail.com>
huitseeker
added a commit
to argumentcomputer/Nova
that referenced
this pull request
May 2, 2024
This implements [Supernova](https://eprint.iacr.org/2022/1758), allowing: - a 'pay-as-you-go' cost structure for folding operations, through the SuperNova folding scheme, - a final SNARK that efficiently compresses an instance of this folded proof, through batching techniques. References: - the [blog post](https://blog.lurk-lang.org/posts/arecibo-supernova/#technical-release-note-supernova-protocol-integration-into-nova) goes into our construction, and links to two more specialized notes on [the `CompressedSNARK` for Supernova](https://hackmd.io/@adr1anh/BJw1g0aBT) along with our variant of the [public input padding issue](https://hackmd.io/@adr1anh/Sy08YaVBa). - the Readme at `src/supernova/Readme.md` This backports the following Arecibo PRs: - argumentcomputer/arecibo#2 - argumentcomputer/arecibo#3 - argumentcomputer/arecibo#10 - argumentcomputer/arecibo#16 - argumentcomputer/arecibo#23 - argumentcomputer/arecibo#30 - argumentcomputer/arecibo#28 - argumentcomputer/arecibo#41 - argumentcomputer/arecibo#45 - argumentcomputer/arecibo#50 - argumentcomputer/arecibo#56 - argumentcomputer/arecibo#51 - argumentcomputer/arecibo#72 - argumentcomputer/arecibo#92 - argumentcomputer/arecibo#95 - argumentcomputer/arecibo#97 - argumentcomputer/arecibo#101 - argumentcomputer/arecibo#110 - argumentcomputer/arecibo#106 - argumentcomputer/arecibo#112 - argumentcomputer/arecibo#114 - argumentcomputer/arecibo#119 - argumentcomputer/arecibo#120 - argumentcomputer/arecibo#127 - argumentcomputer/arecibo#123 - argumentcomputer/arecibo#131 - argumentcomputer/arecibo#174 - argumentcomputer/arecibo#175 - argumentcomputer/arecibo#182 Co-authored-by: WYATT <wyattbenno@gmail.com> Co-authored-by: Hanting Zhang <hantingz@usc.edu> Co-authored-by: Ming <hero78119@gmail.com> Co-authored-by: porcuquine <porcuquine@users.noreply.github.com> Co-authored-by: Samuel Burnham <45365069+samuelburnham@users.noreply.github.com> Co-authored-by: Matej Penciak <96667244+mpenciak@users.noreply.github.com> Co-authored-by: Adrian Hamelink <adrian.hamelink@gmail.com>
huitseeker
added a commit
to argumentcomputer/Nova
that referenced
this pull request
May 3, 2024
This implements [Supernova](https://eprint.iacr.org/2022/1758), allowing: - a 'pay-as-you-go' cost structure for folding operations, through the SuperNova folding scheme, - a final SNARK that efficiently compresses an instance of this folded proof, through batching techniques. References: - the [blog post](https://blog.lurk-lang.org/posts/arecibo-supernova/#technical-release-note-supernova-protocol-integration-into-nova) goes into our construction, and links to two more specialized notes on [the `CompressedSNARK` for Supernova](https://hackmd.io/@adr1anh/BJw1g0aBT) along with our variant of the [public input padding issue](https://hackmd.io/@adr1anh/Sy08YaVBa). - the Readme at `src/supernova/Readme.md` This backports the following Arecibo PRs: - argumentcomputer/arecibo#2 - argumentcomputer/arecibo#3 - argumentcomputer/arecibo#10 - argumentcomputer/arecibo#16 - argumentcomputer/arecibo#23 - argumentcomputer/arecibo#30 - argumentcomputer/arecibo#28 - argumentcomputer/arecibo#41 - argumentcomputer/arecibo#45 - argumentcomputer/arecibo#50 - argumentcomputer/arecibo#56 - argumentcomputer/arecibo#51 - argumentcomputer/arecibo#72 - argumentcomputer/arecibo#92 - argumentcomputer/arecibo#95 - argumentcomputer/arecibo#97 - argumentcomputer/arecibo#101 - argumentcomputer/arecibo#110 - argumentcomputer/arecibo#106 - argumentcomputer/arecibo#112 - argumentcomputer/arecibo#114 - argumentcomputer/arecibo#119 - argumentcomputer/arecibo#120 - argumentcomputer/arecibo#127 - argumentcomputer/arecibo#123 - argumentcomputer/arecibo#131 - argumentcomputer/arecibo#174 - argumentcomputer/arecibo#175 - argumentcomputer/arecibo#182 Co-authored-by: WYATT <wyattbenno@gmail.com> Co-authored-by: Hanting Zhang <hantingz@usc.edu> Co-authored-by: Ming <hero78119@gmail.com> Co-authored-by: porcuquine <porcuquine@users.noreply.github.com> Co-authored-by: Samuel Burnham <45365069+samuelburnham@users.noreply.github.com> Co-authored-by: Matej Penciak <96667244+mpenciak@users.noreply.github.com> Co-authored-by: Adrian Hamelink <adrian.hamelink@gmail.com>
huitseeker
added a commit
to argumentcomputer/Nova
that referenced
this pull request
Jun 8, 2024
This implements [Supernova](https://eprint.iacr.org/2022/1758), allowing: - a 'pay-as-you-go' cost structure for folding operations, through the SuperNova folding scheme, - a final SNARK that efficiently compresses an instance of this folded proof, through batching techniques. References: - the [blog post](https://blog.lurk-lang.org/posts/arecibo-supernova/#technical-release-note-supernova-protocol-integration-into-nova) goes into our construction, and links to two more specialized notes on [the `CompressedSNARK` for Supernova](https://hackmd.io/@adr1anh/BJw1g0aBT) along with our variant of the [public input padding issue](https://hackmd.io/@adr1anh/Sy08YaVBa). - the Readme at `src/supernova/Readme.md` This backports the following Arecibo PRs: - argumentcomputer/arecibo#2 - argumentcomputer/arecibo#3 - argumentcomputer/arecibo#10 - argumentcomputer/arecibo#16 - argumentcomputer/arecibo#23 - argumentcomputer/arecibo#30 - argumentcomputer/arecibo#28 - argumentcomputer/arecibo#41 - argumentcomputer/arecibo#45 - argumentcomputer/arecibo#50 - argumentcomputer/arecibo#56 - argumentcomputer/arecibo#51 - argumentcomputer/arecibo#72 - argumentcomputer/arecibo#92 - argumentcomputer/arecibo#95 - argumentcomputer/arecibo#97 - argumentcomputer/arecibo#101 - argumentcomputer/arecibo#110 - argumentcomputer/arecibo#106 - argumentcomputer/arecibo#112 - argumentcomputer/arecibo#114 - argumentcomputer/arecibo#119 - argumentcomputer/arecibo#120 - argumentcomputer/arecibo#127 - argumentcomputer/arecibo#123 - argumentcomputer/arecibo#131 - argumentcomputer/arecibo#174 - argumentcomputer/arecibo#175 - argumentcomputer/arecibo#182 Co-authored-by: WYATT <wyattbenno@gmail.com> Co-authored-by: Hanting Zhang <hantingz@usc.edu> Co-authored-by: Ming <hero78119@gmail.com> Co-authored-by: porcuquine <porcuquine@users.noreply.github.com> Co-authored-by: Samuel Burnham <45365069+samuelburnham@users.noreply.github.com> Co-authored-by: Matej Penciak <96667244+mpenciak@users.noreply.github.com> Co-authored-by: Adrian Hamelink <adrian.hamelink@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SuperNovaAugmentedCircuitParams
to be passed by reference intest_recursive_circuit_with
function and associated instances intest.rs
.SuperNovaAugmentedCircuit::new
method to match changes in thetest_recursive_circuit_with
function.synthesize_non_base_case
andsynthesize
functions incircuit.rs
, changing from owned types to references to reduce unnecessary cloning.circuit.rs
.