Move memoset to coroutine module. #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porcuquine
force-pushed
the
coroutines
branch
from
6d638bb
to
c72a732
Compare
huitseeker
approved these changes
Jan 13, 2024
porcuquine
force-pushed
the
coroutines
branch
from
f9d0a29
to
5bd5d95
Compare
huitseeker
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @gabriel-barrett, it definitely no longer makes sense to house the
memosetmodule incoprocessors.Although
memoset::query::Queryimplements something conceptually like aCoprocessor, it's not identical. We had thought maybe we could still use theCoprocessormechanism to implement the proving circuits, but that also seems to be a mismatch.So, to minimize confusion, as we gradually concretize the semantics and lexicon, we decided to re-house
memosetentirely. The reason for the newcoroutinemodule is that we think this is the lexical equivalent of coprocessor. It may be that aCoroutinetrait emerges, implemented byQueryvariants. TheCoprocessortrait structure won't be directly applicable because of the demands of mutual recursion.More thought is needed, but the current PR only does the most conservative thing.