ci: Fail e2e tests when PR base is main
#45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
storojs72
approved these changes
Dec 14, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 15, 2023
* Remove e2e contract and integrative components * Update README * Add Bn256/Grumpkin curves arithmetics * Move constants (JSON) files to 'src/blocks/poseidon' path * Add optimized Poseidon library * Add Zeromorph library * Stub for e2e integration testing * chore(doc): update README for main - Repository structure - Overview of the different feature branches * chore(doc): SPDX License identifier * chore(doc): comment Bn256/Grumpkin files * chore(doc): fixed solidity doc for Bn256/Grumpkin files * chore(doc): README for Grumpkin Bn256 * chore(doc): pasta solidity doc & README * chore(doc): new doc + fix - Fix NatSpec comment order over Pallas.sol and Vesta.sol - Added Solidity comments over PoseidonNeptuneU24Optimized.sol and Sponge.sol - Added README in poseidon folder * chore(doc): doc for all cryptographic blocks - Solidity doc for all cryptographic blocks file - README in src/blocks to explain each file and their content - Fixed typo in library name * chore(doc): doc for Utilities.sol * Skip execution of e2e integration testing on main branch * chore(doc): fix fmt * Requested changes and adjustments * ci: Fail e2e tests when PR base is `main` (#45) * Add Sponge library that supports optimized Poseidon * chore(doc): followed review comments * chore(doc): added NatSpec comments - NatSpec for implementation of Sponge over the Optimized Poseidon library. * chore(doc): fixed fmt --------- Co-authored-by: Thomas Chataigner <tom.chataigner@yahoo.fr> Co-authored-by: Samuel Burnham <45365069+samuelburnham@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main(tested successfully).pushtrigger for unit test CI in favor of running only onpull_requestandworkflow_dispatchrather than every commit, which will save on CI cost in the long run. @storojs72 if you think thepushtrigger is needed I can revert.fail-fast: truestrategy as it's the default setting,