Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: minidump-stackwalk cyborg output #296

Closed
Gankra opened this issue Nov 17, 2021 · 1 comment
Closed

feature: minidump-stackwalk cyborg output #296

Gankra opened this issue Nov 17, 2021 · 1 comment
Labels
enhancement Would improve the quality of the project, but isn't causing problems

Comments

@Gankra
Copy link
Collaborator

Gankra commented Nov 17, 2021

Currently you can only get human output or machine (json) output. While you could run the tool twice, this is fairly wasteful. Ideally we would have a cyborg output mode that does both.

The main issue is that current minidump-stackwalk only has the notion of one "output". You can specify whether that's stdout or --output-file, but it's still just one output.

The simplest solution is this tentative syntax:

--cyborg=path/to/write.json

I figure in typical usage you want the human output to still hit stdout, so keeping the human output as the "default" output that goes to stdout (and can still be configured with --output-file) makes the most sense to me?

This would be useful for https://bugzilla.mozilla.org/show_bug.cgi?id=1487410

@Gankra Gankra added the enhancement Would improve the quality of the project, but isn't causing problems label Nov 23, 2021
@Gankra
Copy link
Collaborator Author

Gankra commented Nov 30, 2021

Implemented in #316

@Gankra Gankra closed this as completed Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Would improve the quality of the project, but isn't causing problems
Projects
None yet
Development

No branches or pull requests

1 participant