Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rescale images used in Input #2054

Merged
merged 11 commits into from
Apr 27, 2022
Merged

Rescale images used in Input #2054

merged 11 commits into from
Apr 27, 2022

Conversation

alexbruy
Copy link
Contributor

Resize/rescale images selected for using in Input according to the Mergin project setting (defined in the QGIS plugin). Keep EXIF data of the original file.

Setting image quality done in QGIS plugin, related pull-request MerginMaps/qgis-plugin/pull/383

Fixes #841.

@alexbruy
Copy link
Contributor Author

Seems we should upgrade exiv2 to 1.0.0 or build with C++11/C++14 compiler as it uses auto_ptr.

Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really good, good job @alexbruy! 🎉

core/imageutils.cpp Outdated Show resolved Hide resolved
app/inpututils.cpp Outdated Show resolved Hide resolved
app/qml/ExternalResourceBundle.qml Outdated Show resolved Hide resolved
app/qml/ExternalResourceBundle.qml Outdated Show resolved Hide resolved
@PeterPetrik
Copy link
Contributor

Ok, I update EXIV in SDK

@tomasMizera tomasMizera added the blocked Not possible to continue until other task is resolved label Apr 21, 2022
@PeterPetrik
Copy link
Contributor

SDK issue: MerginMaps/mobile-sdk#68

@PeterPetrik PeterPetrik removed REQUIRE NEW SDK blocked Not possible to continue until other task is resolved labels Apr 22, 2022
@PeterPetrik PeterPetrik merged commit a06503a into dev-1.4.1 Apr 27, 2022
@PeterPetrik PeterPetrik deleted the image-quality branch April 27, 2022 07:08
tomasMizera pushed a commit that referenced this pull request May 11, 2022
* rescale images according to the PhotoQuality setting set in the QGIS
project (fix #841)

Co-authored-by: PeterPetrik <zilolv@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants