Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note on Update every 10th row #4

Closed
ryansolid opened this issue Apr 14, 2020 · 1 comment
Closed

Note on Update every 10th row #4

ryansolid opened this issue Apr 14, 2020 · 1 comment

Comments

@ryansolid
Copy link

ryansolid commented Apr 14, 2020

I think it is good to know. And it is definitely a consideration for libraries in general. But I wanted to point out from a reactive standpoint I think this test doesn't matter for the list reconciler very much. Nested updates unless they replace the whole element avoid the list reconciler (which is why reactive is fast). From this perspective I think that makes udomdiff still the better choice for a reactive library?

EDIT: I see replace is the big one. Probably because doesn't do the shortcut there. I wonder how much code that'd take to remedy. And the scaling of append. Interesting. That deserves further investigation.

@luwes
Copy link
Owner

luwes commented Apr 14, 2020

good point @ryansolid. I changed the test a little so the node is actually fully replaced so it has some effect on reconcile metrics. see here

childNodes[i] = new Nody(parent, i + '!');

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants