Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme links to 404 of custom metrics API. #50

Closed
Jandev opened this issue Oct 4, 2021 · 1 comment
Closed

Readme links to 404 of custom metrics API. #50

Jandev opened this issue Oct 4, 2021 · 1 comment

Comments

@Jandev
Copy link

Jandev commented Oct 4, 2021

The readme contains a link referencing to a 404, probably an old link:

A brief walkthrough what the statements mean:

horizontal-pod-autoscaler-use-rest-clients: "true" tells the controller manager to look for the custom metrics API

It's linking to https://github.com/kubernetes/community/blob/master/contributors/design-proposals/custom-metrics-api.md, which doesn't exist anymore.

I think the new link should be https://github.com/kubernetes/community/blob/master/contributors/design-proposals/instrumentation/custom-metrics-api.md, with the instrumentation folder added in the link.

@Jandev
Copy link
Author

Jandev commented Oct 4, 2021

Nevermind, I see there's an active PR #41 addressing this issue already.

@Jandev Jandev closed this as completed Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant