Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataInputQueue nullptr check #112

Merged
merged 1 commit into from
Apr 17, 2021
Merged

Conversation

themarpe
Copy link
Collaborator

This checks if a nullptr was passed to send method of DataInputQueue and which also applies to None being passed from Python bindings

Copy link
Collaborator

@SzabolcsGergely SzabolcsGergely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Is there a context where this issue came up (out of curiosity) or just general fix?

@Luxonis-Brandon
Copy link
Contributor

I was just about to ask the same question actually. Mainly because I'm overly-optimistically-hoping that this is the fix to Raspberry Pi issue. But I'm guessing this is likely not the resolution to that but rather something discovered in that hunt.

@themarpe
Copy link
Collaborator Author

themarpe commented Apr 16, 2021

Unfortunately doesn't addresses any burning issue - was a tad stale from a couple of days ago as I was working on a custom script and sent None type instead of actual message (returned by a "void" function in Python). Programming mistake on my end but looked quite serious at first glance. (As the program segfaulted)

@Luxonis-Brandon
Copy link
Contributor

Thanks. Makes sense.

@themarpe themarpe merged commit c6b24dd into develop Apr 17, 2021
@themarpe themarpe deleted the datainputqueue_nullptr_check branch April 17, 2021 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants