Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add convenience headers in depthai/pipeline #153

Merged
merged 2 commits into from
Jun 14, 2021
Merged

Add convenience headers in depthai/pipeline #153

merged 2 commits into from
Jun 14, 2021

Conversation

kunaltyagi
Copy link
Contributor

No description provided.

@kunaltyagi kunaltyagi force-pushed the headers branch 2 times, most recently from 2f8409b to 2d33666 Compare June 11, 2021 04:53
@SzabolcsGergely
Copy link
Collaborator

Please target develop w/ PRs.

@kunaltyagi kunaltyagi changed the base branch from main to develop June 11, 2021 07:39
@themarpe
Copy link
Collaborator

Does this enable anything outside of this refactor?
If not its IMO unnecessary, as it just moves it to a separate include.
Otherwise I'd lean more on lowercase naming.

@kunaltyagi
Copy link
Contributor Author

Could you please expand a bit more? This doesn't add any features, just allows a user to include a single header for all nodes while creating a pipeline.

@themarpe
Copy link
Collaborator

I think it could come handy in StreamPacketParser from #150 .
Then I'd go with lowercase: nodes.hpp & datatypes.hpp and we can reuse in #150 as well (StreamPacketParser.cpp)

@kunaltyagi kunaltyagi changed the title Add convenienve headers in depthai/pipeline Add convenience headers in depthai/pipeline Jun 12, 2021
@themarpe themarpe merged commit d7ab827 into luxonis:develop Jun 14, 2021
@kunaltyagi kunaltyagi deleted the headers branch June 14, 2021 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themarpe themarpe themarpe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kunaltyagi @SzabolcsGergely @themarpe