Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 5x5 bilateral filter in stereo depth; add runtime con… #159

Merged
merged 11 commits into from
Jun 21, 2021

Conversation

SzabolcsGergely
Copy link
Collaborator

@SzabolcsGergely SzabolcsGergely commented Jun 14, 2021

…figurability for stereo depth confidence threshold/bilateral filter sigma value.

In the future we will add more config options like: switching depth mode at runtime, configurable stereo match parameters (census kernel settings) etc.

Related PR: luxonis/depthai-shared#39

Copy link
Collaborator

@themarpe themarpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we should combine the median filter enum to a common place.
Otherwise LGTM

Copy link
Collaborator

@themarpe themarpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the new message is missing in hierarchy

@SzabolcsGergely
Copy link
Collaborator Author

I think the new message is missing in hierarchy

It's added here

@SzabolcsGergely SzabolcsGergely changed the base branch from depth_post_filter to develop June 17, 2021 19:11
@Luxonis-Brandon Luxonis-Brandon added this to In Progress in Gen2 Phase II Efforts Jun 17, 2021
@SzabolcsGergely SzabolcsGergely merged commit da470b0 into develop Jun 21, 2021
Gen2 Phase II Efforts automation moved this from In Progress to Done Jun 21, 2021
@SzabolcsGergely SzabolcsGergely deleted the bilateral_filter branch June 21, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants