-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spdlog version change #239
Conversation
Additional information about the change - both ROS and depthai depend on spdlib library, but not same version. When depthai gets dynamically linked it brings in "default" (external linkage) symbols, which in turn depends on load order to determine which symbols are finally selected. The solution is to make the spdlog that depthai uses completely "private" (eg. symbols hidden) as there is no need to expose this for library consumers as it doesn't come up in any public interface. In that case, in runtime of the final program, there are 2 spdlog libraries running, one for ROS and a competely separate one for depthai internally. This could be done for more dependent libraries, which are private to the depthai, but we've opted for this one only as it currently causes issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after typo fix
Spdlog changed to avoid linking issues when using with ros2