Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spdlog version change #239

Merged
merged 18 commits into from
Oct 30, 2021
Merged

Spdlog version change #239

merged 18 commits into from
Oct 30, 2021

Conversation

saching13
Copy link
Contributor

Spdlog changed to avoid linking issues when using with ros2

@themarpe
Copy link
Collaborator

Additional information about the change - both ROS and depthai depend on spdlib library, but not same version. When depthai gets dynamically linked it brings in "default" (external linkage) symbols, which in turn depends on load order to determine which symbols are finally selected.

The solution is to make the spdlog that depthai uses completely "private" (eg. symbols hidden) as there is no need to expose this for library consumers as it doesn't come up in any public interface. In that case, in runtime of the final program, there are 2 spdlog libraries running, one for ROS and a competely separate one for depthai internally.

This could be done for more dependent libraries, which are private to the depthai, but we've opted for this one only as it currently causes issues

Copy link
Collaborator

@themarpe themarpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after typo fix

@saching13 saching13 changed the base branch from main to develop October 26, 2021 21:50
@saching13 saching13 merged commit f469f73 into develop Oct 30, 2021
@saching13 saching13 deleted the ros2-main-gen2 branch October 30, 2021 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants