enable build in vscode, custom toolchain+include #258
Conversation
diablodale
force-pushed
the
fix246_vscodebuild
branch
from
013820a
to
bada0ee
Compare
cmake/depthaiDependencies.cmake
Outdated
| # include optional dependency cmake | ||
| if(DEFINED DEPTHAI_DEPENDENCY_INCLUDE) | ||
| include(${DEPTHAI_DEPENDENCY_INCLUDE} OPTIONAL) | ||
| endif() |
There was a problem hiding this comment.
depthaiDependencies.cmake are installed as well to specify correctly all dependencies.
Any requirement to carry over the specified include over to be installed as well?
Otherwise as its guarded LGTM for non-installed use case
There was a problem hiding this comment.
depthaiDependencies.cmake is part of the cmake by a fixed include() and a git tracked file. Therefore, it is more troublesome to customize it (always have to merge, conflicts, etc.)...separating the upstream from the local customize via vars. One is the toolchain (already done), second and third are dependencies and libraries (mostly for opencv).
Sorry, I don't understand your question. Could you word it another way?
Also, I've been considering if the two I added THIRDPARTY_OPENCV_LIBRARIES and DEPTHAI_DEPENDENCY_INCLUDE should have option() for them. If you think good to have, then I can update the PR.
There was a problem hiding this comment.
Worded it oddly - meant to ask if the DEPTHAI_DEPENDENCY_INCLUDE file should be installed as well, so that consumers get this information as well, or should this be for local use only?
Yeah, I think it'd be good for discoverability. One a path and one a string type.
There was a problem hiding this comment.
I slightly lean towards not installing the file DEPTHAI_DEPENDENCY_INCLUDE.
- in my specific usage, it is only extra stuff needed to compile depthai and its test/examples. For example, I use TBB, IPP, and Eigen with my private OpenCV. So I need to find_package() those so that later cmake can correctly find includes and link EXEs.
- I tend to think that the devs that need this (a minority) will privately manage their
DEPTHAI_DEPENDENCY_INCLUDEfile for depthai itself -and- also for their final EXE. In my case, I have a cmake for my final EXE which manages its own find_package(), points to the depthai cmake, etc. For example, I need OpenCV directly in my EXE so I find_package() for TBB, IPP, and Eigen in the app's cmake. So I tend to think a dev needing this will self-manage and that they only need a way to adapt depthai without having to make private commits to it.
I'll add options for the two and force push after this.
There was a problem hiding this comment.
Sounds good - lets leave it for local only
There was a problem hiding this comment.
pushed, ci is running
|
I don't think this is a me/code issue. It complains of
|
fixes #246
full details on how this fix can be used in vscode is in the above issue.