Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dai::initialize() thread/except safety #277

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

diablodale
Copy link
Contributor

fixes #276 by using Meyer singleton + lambda.

This passed all 60/61 of the depthai-core test suite. The one test fails due to my OAK-D not having RGBD cali data in EEPROM.

[ctest] 
[ctest] 98% tests passed, 1 tests failed out of 61
[ctest] 
[ctest] Total Test time (real) = 1279.47 sec
[ctest] 
[ctest] The following tests FAILED:
[ctest] 	 51 - rgb_depth_aligned (Failed)
[ctest] Errors while running CTest
[ctest] CTest finished with return code 8

@Luxonis-Brandon
Copy link
Contributor

Thanks for all the help. We can walk you through how to re-calibrate your OAK-D to get RGB calibration into it and we're also more than happy to just send you an additional OAK-D to say (1) thanks for all the help and (2) sorry yours was one of the very few that didn't get RGB calibration baked in (only some super-tiny number didn't get RGB cal).

If you'd like to do so feel free to shoot us an email at support at luxonis dot com.

Copy link
Collaborator

@themarpe themarpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@themarpe themarpe merged commit f423d94 into luxonis:develop Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

depthai::initialize() not thread or exception safe; recommend using singleton
3 participants