-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gen2 common objdet #34
Conversation
…ng mobilenet into this branch to make example usage a bit easier.
It's ultimately to make transfering larger pieces of data off the esp32 easier. By separating metadata and message data we don't have to deal with finding the location of metadata and excluding it from the transmission. It was fine with smaller message because we could fit the entire message in memory and parse it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mentioned comments and please remove standaloneYOLOExample
. Suitable location would be depthai-experiments
@@ -0,0 +1,33 @@ | |||
#pragma once |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, good call, I can remove all the old CommonObjDet stuff.
dai::DetectionNetworkProperties properties; | ||
|
||
public: | ||
Input input{*this, "in", Input::Type::SReceiver, {{DatatypeEnum::Buffer, true}}}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should only accept ImgFrame types (as input w&h are required, right?)
Input input{*this, "in", Input::Type::SReceiver, {{DatatypeEnum::ImgFrame, false}}};
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed.
|
||
public: | ||
Input input{*this, "in", Input::Type::SReceiver, {{DatatypeEnum::Buffer, true}}}; | ||
Output out{*this, "out", Output::Type::MSender, {{DatatypeEnum::Buffer, false}}}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outputs ImgDetections type:
Output out{*this, "out", Output::Type::MSender, {{DatatypeEnum::ImgDetections, false}}};
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SPIOut node is expecting DatatypeEnum::Buffer for input though. Can I leave it as DatatypeEnum::Buffer or is there some other way around this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SPIOut is expecting Buffer or its descendants (think, derived objects / polymorphism), same as XLinkIn.
Therefore they can both accept any messages.
@jonngai One extra request - can you derive |
Hey @themarpe , I set that up but still had to override a number of methods since DetectionNetwork has its own inputs, outputs and properties. Let me know if there's a better way of handling this or if this'll do for the time being. Thanks. |
No description provided.