Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gen2 common objdet #34

Merged
merged 57 commits into from
Jan 12, 2021
Merged

Gen2 common objdet #34

merged 57 commits into from
Jan 12, 2021

Conversation

jonngai
Copy link
Contributor

@jonngai jonngai commented Jan 5, 2021

No description provided.

…ng mobilenet into this branch to make example usage a bit easier.
It's ultimately to make transfering larger pieces of data off the esp32 easier.
By separating metadata and message data we don't have to deal with finding the location of metadata and excluding it from the transmission.
It was fine with smaller message because we could fit the entire message in memory and parse it.
@Luxonis-Brandon Luxonis-Brandon added the Gen2 Feature for or issue with Gen2 label Jan 5, 2021
@Luxonis-Brandon Luxonis-Brandon added this to In progress in Gen2 Phase I Delivery via automation Jan 5, 2021
Copy link
Collaborator

@themarpe themarpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mentioned comments and please remove standaloneYOLOExample. Suitable location would be depthai-experiments

@@ -0,0 +1,33 @@
#pragma once
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good call, I can remove all the old CommonObjDet stuff.

dai::DetectionNetworkProperties properties;

public:
Input input{*this, "in", Input::Type::SReceiver, {{DatatypeEnum::Buffer, true}}};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should only accept ImgFrame types (as input w&h are required, right?)

Input input{*this, "in", Input::Type::SReceiver, {{DatatypeEnum::ImgFrame, false}}};

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed.


public:
Input input{*this, "in", Input::Type::SReceiver, {{DatatypeEnum::Buffer, true}}};
Output out{*this, "out", Output::Type::MSender, {{DatatypeEnum::Buffer, false}}};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outputs ImgDetections type:

Output out{*this, "out", Output::Type::MSender, {{DatatypeEnum::ImgDetections, false}}};

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SPIOut node is expecting DatatypeEnum::Buffer for input though. Can I leave it as DatatypeEnum::Buffer or is there some other way around this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SPIOut is expecting Buffer or its descendants (think, derived objects / polymorphism), same as XLinkIn.

Therefore they can both accept any messages.

@themarpe
Copy link
Collaborator

@jonngai One extra request - can you derive DetectionNetwork from NeuralNetwork?

@jonngai
Copy link
Contributor Author

jonngai commented Jan 11, 2021

@jonngai One extra request - can you derive DetectionNetwork from NeuralNetwork?

Hey @themarpe , I set that up but still had to override a number of methods since DetectionNetwork has its own inputs, outputs and properties. Let me know if there's a better way of handling this or if this'll do for the time being. Thanks.

@jonngai jonngai merged commit ab78610 into gen2_develop Jan 12, 2021
@Luxonis-Brandon Luxonis-Brandon moved this from In progress to Done in Gen2 Phase I Delivery Jan 12, 2021
@SzabolcsGergely SzabolcsGergely deleted the gen2_common_objdet branch February 19, 2021 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gen2 Feature for or issue with Gen2
Development

Successfully merging this pull request may close these issues.

None yet

3 participants