Color/MonoCamera: add API to configure image orientation #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themarpe
reviewed
Jan 11, 2021
|
|
||
| // Get camera image orientation | ||
| CameraImageOrientation ColorCamera::getImageOrientation() const { | ||
| // TODO: in case of AUTO, see if possible to return actual value determined by device? |
There was a problem hiding this comment.
Right now unfortunately no - all of the node building happens before device is known.
That said, we could add device type (OAK-1, OAK-D, ....) as a part of pipeline constructor, which would in turn help us resolve some of these values. This still doesn't solve all of it, but might be a good addition down the road.
themarpe
approved these changes
Jan 11, 2021
SzabolcsGergely
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR: luxonis/depthai-shared#15