Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable queues of size=0 which only do callbacks #378

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

diablodale
Copy link
Contributor

Add support for Queues used by depthai-core to have size=0 and therefore only call callbacks.

I've been using this for about a week; size=0 works well in my app.
Passes test+examples, though they don't actively test size=0.

Copy link
Collaborator

@themarpe themarpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some readability nitpicks
Otherwise LGTM

include/depthai/utility/LockingQueue.hpp Outdated Show resolved Hide resolved
include/depthai/utility/LockingQueue.hpp Outdated Show resolved Hide resolved
include/depthai/utility/LockingQueue.hpp Outdated Show resolved Hide resolved
include/depthai/utility/LockingQueue.hpp Outdated Show resolved Hide resolved
- minor optimize LockingQueue
- fixes luxonis#366
@diablodale
Copy link
Contributor Author

I force pushed the requested changes. Would you start CI?

@themarpe themarpe merged commit e23ee4c into luxonis:develop Feb 16, 2022
@themarpe themarpe mentioned this pull request May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants