Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add detection NN example #50

Merged
merged 14 commits into from
Feb 15, 2021
Merged

Add detection NN example #50

merged 14 commits into from
Feb 15, 2021

Conversation

SzabolcsGergely
Copy link
Collaborator

@SzabolcsGergely SzabolcsGergely commented Feb 8, 2021 •
edited

Added getLayerInt32 for NN results, used by deeplabv3 for example
Added mobilenet device side decoding example
Added tiny yolo v3 device side decoding example
Improved Detection network API

Fix FW bugs: https://gitlab.com/luxonis/depthai/-/merge_requests/104

@SzabolcsGergely SzabolcsGergely changed the title Detection NN example Add detection NN example Feb 8, 2021
themarpe
themarpe requested changes Feb 9, 2021
View reviewed changes
Copy link
Collaborator

@themarpe themarpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the requested changes.
Rationally behind the ImgDetections move from reference to getter?
And in case it remains, add a setter as well to be able to create ImgDetections message and send it to the device

include/depthai/pipeline/node/DetectionNetwork.hpp Show resolved Hide resolved
examples/src/camera_mobilenet_example.cpp Outdated Show resolved Hide resolved
include/depthai/pipeline/datatype/ImgDetections.hpp Outdated Show resolved Hide resolved
@SzabolcsGergely SzabolcsGergely mentioned this pull request Feb 12, 2021
Merged
@SzabolcsGergely
Copy link
Collaborator Author

SzabolcsGergely commented Feb 12, 2021 •
edited

LGTM apart from the requested changes.
Rationally behind the ImgDetections move from reference to getter?
And in case it remains, add a setter as well to be able to create ImgDetections message and send it to the device

Switched back to reference, fixed setNumFramePools for detection NN

@SzabolcsGergely SzabolcsGergely merged commit 14e414b into gen2_develop Feb 15, 2021
@SzabolcsGergely SzabolcsGergely deleted the detection_nn branch February 15, 2021 09:30
@Luxonis-Brandon Luxonis-Brandon added this to In progress in Gen2 Phase I Delivery via automation Feb 15, 2021
@Luxonis-Brandon Luxonis-Brandon moved this from In progress to Done in Gen2 Phase I Delivery Feb 15, 2021
@Luxonis-Brandon Luxonis-Brandon added Gen2 Feature for or issue with Gen2 enhancement New feature or request labels Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themarpe themarpe themarpe approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Gen2 Feature for or issue with Gen2
Projects
Gen2 Phase I Delivery
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SzabolcsGergely @themarpe @Luxonis-Brandon