Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add confirmation that the device has booted up #51

Merged
merged 2 commits into from
Feb 10, 2021
Merged

Add confirmation that the device has booted up #51

merged 2 commits into from
Feb 10, 2021

Conversation

kunaltyagi
Copy link
Contributor

Found useful while debugging:

$ ./examples/system_information 
terminate called after throwing an instance of 'std::runtime_error'
  what():  Failed to find device after booting, error message: X_LINK_DEVICE_NOT_FOUND
Aborted (core dumped)
$ lsusb
Bus 004 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
Bus 003 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 002 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
Bus 001 Device 011: ID 03e7:2485  
Bus 001 Device 002: ID 04f3:0103 Elan Microelectronics Corp. ActiveJet K-2024 Multimedia Keyboard

@Luxonis-Brandon
Copy link
Contributor

Thanks @kunaltyagi !

themarpe
themarpe requested changes Feb 9, 2021
View reviewed changes
Copy link
Collaborator

@themarpe themarpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR - will merge after mentioned changes

src/xlink/XLinkConnection.cpp Outdated
@@ -199,10 +199,14 @@ void XLinkConnection::initDevice(const DeviceInfo& deviceToInit, XLinkDeviceStat
throw std::runtime_error("Failed to find device (" + std::string(deviceToBoot.desc.name) + "), error message: " + convertErrorCodeToString(rc));
}

bool boot_status;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to bootStatus (camelCase is our preferred variable naming convention)

@themarpe themarpe merged commit f9558c3 into luxonis:gen2_develop Feb 10, 2021
@kunaltyagi kunaltyagi deleted the throw.failed_boot branch February 11, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themarpe themarpe themarpe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kunaltyagi @Luxonis-Brandon @themarpe