Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robots Filter do not throw exception #1947

Closed
nadar opened this issue Aug 18, 2019 · 1 comment · Fixed by #1959
Closed

Robots Filter do not throw exception #1947

nadar opened this issue Aug 18, 2019 · 1 comment · Fixed by #1959
Assignees

Comments

@nadar
Copy link
Member

nadar commented Aug 18, 2019

A separate channel should be available for robots filter message, maybe an api to call. Otherwise robots filter are exception which will be transmitted to error api.

https://github.com/luyadev/luya/blob/master/core/web/filters/RobotsFilter.php

@nadar
Copy link
Member Author

nadar commented Sep 8, 2019

Maybe in a first step we could add new exception which are whitelisted by default. For example

  • luya\exceptions\WhitelistedException

also whitelist more exception which might not be usefull for error reporting as the application works as expected:

  • yii\base\InvalidRouteException
  • yii\web\NotFoundHttpException
  • yii\web\ForbiddenHttpException
  • yii\web\MethodNotAllowedHttpException
  • yii\web\UnauthorizedHttpException
  • yii\web\BadRequestHttpException

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant