Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MFA provider "google" is really "totp" #25

Closed
delroth opened this issue Dec 28, 2018 · 2 comments · Fixed by #29
Closed

MFA provider "google" is really "totp" #25

delroth opened this issue Dec 28, 2018 · 2 comments · Fixed by #29

Comments

@delroth
Copy link

delroth commented Dec 28, 2018

The MFA provider currently called "google" is just a TOTP implementation and doesn't have anything specifically to do with Google Authenticator. I use a different TOTP wallet app on my phone and haven't noticed any problem with it.

How about having "totp" as the canonical name for this provider and "google" as an alias? This would make it clearer what this provider actually works with.

@Luzifer
Copy link
Owner

Luzifer commented Dec 28, 2018

Indeed as it's currently built it is a TOTP provider using quite specific settings which are used by the Google Authenticator. TOTP allows 6 or 8 digits and different rotation times.

Also "Google Authenticator" is a quite common term used for these TOTP implementation. In my experience not many people are aware of the existence of the TOTP authentication mechanism but most are aware of the "Google Authenticator".

About the app usage: Sure, you can use every app / service you like as soon as they support the settings mentioned above: Authy, LastPass, Vault-TOTP, …

Regarding the name change: I think this should go along with adding more configuration options for the TOTP provider. For backwards compatibility the provider must also listen to the google provider id.

Luzifer added a commit that referenced this issue Dec 28, 2018
Signed-off-by: Knut Ahlers <knut@ahlers.me>
Luzifer added a commit that referenced this issue Dec 28, 2018
Signed-off-by: Knut Ahlers <knut@ahlers.me>
@Luzifer
Copy link
Owner

Luzifer commented Dec 28, 2018

The fully configurable TOTP provider is implemented into master and will soon be released. The default is now to use totp as a name and google acts as a backwards compatible fallback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants