Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improper port handling in LDAP #33

Closed
dhain opened this issue Jan 17, 2019 · 2 comments
Closed

Improper port handling in LDAP #33

dhain opened this issue Jan 17, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@dhain
Copy link

dhain commented Jan 17, 2019

When attempting to connect to an LDAP server with a nonstandard port number, I get the following in the logs:

time="2019-01-17T19:01:24Z" level=error msg="Error while handling auth request" error="Unable to connect to LDAP: LDAP Result Code 200 \"Network Error\": dial tcp: address localhost:3389:3389: too many colons in address"

A quick glance at the code reveals the problem, in auth_ldap.go in dial(), the host variable has the colon and port number in it already, and gets the port number appended a second time by the Sprintf calls.

@Luzifer Luzifer added the bug Something isn't working label Jan 17, 2019
@Luzifer
Copy link
Owner

Luzifer commented Jan 17, 2019

Thanks for bringing this to my attention! It has been fixed in v0.15.1.

@dhain
Copy link
Author

dhain commented Jan 18, 2019

Thanks for the quick turn-around! Confirmed fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants