Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge into upstream #5

Open
Spiffyk opened this issue Aug 15, 2021 · 3 comments
Open

Merge into upstream #5

Spiffyk opened this issue Aug 15, 2021 · 3 comments

Comments

@Spiffyk
Copy link

Spiffyk commented Aug 15, 2021

Hi. I would like to add LV2 support to my plugin, LibreArp. However, I'm not really comfortable linking it to an unofficial JUCE repository.

Seeing as there are no issues open here, I would like to ask if there are any outstanding problems with the LV2 patch and, if there aren't, wouldn't it be a good idea to consider opening a pull request to the official repository to have the LV2 wrapper merged? The JUCE developers have expressed their interest in LV2 in the past, too, encouraging people to submit a PR. Maybe now would be the time to try and get the changes reviewed and eventually merged into the official JUCE branch?

@KottV
Copy link
Member

KottV commented Aug 15, 2021

Hi!

This fork grows from the @falkTX's code from PR that you mentioned. There is his continuation of work: https://github.com/DISTRHO/JUCE please note that it contains more additions than just LV2 support.

This fork is even with upstream JUCE release 6.0.8 and has only LV2 wrapper and exporter.

According PR to JUCE upstream - I don't think it's pretty ready. At least it should have support for all other platforms such Windows and MacOS IMHO.

Anyway you can use it as separate source for building LV2 only version, as for example https://github.com/surge-synthesizer/surge does.

@KottV
Copy link
Member

KottV commented Aug 15, 2021

Also we have LV2 builds of LibreArp in Geekos DAW project and it works good :)

https://build.opensuse.org/package/show/home:geekositalia:daw/LibreArp

@Spiffyk
Copy link
Author

Spiffyk commented Aug 15, 2021

Thanks for the reply.

I'm actually planning to add a separate branch to LibreArp that will be linked to your fork of JUCE, making an "experimental" LV2 version readily available via GitLab's pipelines.

I have heard of your LV2 builds of LibreArp, good job on those, and thanks for maintaining them!

Anyway, I agree that if LV2 itself is cross-platform, so should be the JUCE version supporting it. I just wanted to open this issue to make it known that there is genuine interest in getting LV2 upstreamed at some point, when it's ready :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants