Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimized search doesn't work properly #1

Closed
lvapeab opened this issue Dec 31, 2016 · 2 comments
Closed

Optimized search doesn't work properly #1

lvapeab opened this issue Dec 31, 2016 · 2 comments
Assignees
@lvapeab
Labels
bug

Comments

@lvapeab
Copy link
Owner

lvapeab commented Dec 31, 2016

Optimized search doesn't work properly. When translating Europarl (e.g.) performance drops from ~23 Bleu to ~13.
@lvapeab lvapeab added the bug label Dec 31, 2016
@lvapeab lvapeab self-assigned this Dec 31, 2016
@lvapeab
Copy link
Owner Author

lvapeab commented Jan 11, 2017

Fixed in staged_keras_wrapper: lvapeab/multimodal_keras_wrapper@aed24df

@lvapeab lvapeab closed this as completed Jan 11, 2017
@lvapeab
Copy link
Owner Author

lvapeab commented Jan 12, 2017

That was a fix for models without attention.
Models with attention were fixed in the NMT-Keras repo: 60a90a7

@lvapeab lvapeab reopened this Jan 12, 2017
@lvapeab lvapeab closed this as completed Jan 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lvapeab lvapeab

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lvapeab