Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report does not show compatibility issue #89

Open
nillepillan opened this issue Feb 5, 2019 · 1 comment
Open

Report does not show compatibility issue #89

nillepillan opened this issue Feb 5, 2019 · 1 comment

Comments

@nillepillan
Copy link

nillepillan commented Feb 5, 2019

Hi!
I made a change in my header file, named functions differently:

Add(

changed to

AddA(

Created dumps:
nillepillan:/repo/ABICC$ abi-dumper lib.so.0 -o ABI-0.dump -lver 0
nillepillan:
/repo/ABICC$ abi-dumper lib.so.1 -o ABI-1.dump -lver 1

When comparing the dumps I get:

nillepillan:~/repo/ABICC$ abi-dumper -compare ABI-0.dump new/ABI-1.dump
Removed _ZN29ComponentDescriptorCollection3AddEP19ComponentDescriptor
Added _ZN29ComponentDescriptorCollection4AddAEP19ComponentDescriptor

But when running checker there are no problems:

nillepillan:~/repo/ABICC$ abi-compliance-checker -l test -old ABI-0.dump -new new/ABI-1.dump
Preparing, please wait ...
Comparing ABIs ...
Comparing APIs ...
Creating compatibility report ...
Binary compatibility: 100%
Source compatibility: 100%
Total binary compatibility problems: 0, warnings: 0
Total source compatibility problems: 0, warnings: 0
Report: compat_reports/test/1_to_2/compat_report.html

Any ideas what could be wrong?

BR,
Pernilla

@adriaandegroot
Copy link

adriaandegroot commented Mar 2, 2021

You may have some luck updating abi-dumper to version 1.2. I had something similar (described in lvc/abi-dumper#27 : renaming a symbol gives 100% compatibility when it doesn't work at all). Replacing my OS's packaged abi-dumper script by the one from git fixed that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants