Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

approvers list #4

Open
kennedyi opened this issue Aug 25, 2022 · 1 comment
Open

approvers list #4

kennedyi opened this issue Aug 25, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@kennedyi
Copy link

kennedyi commented Aug 25, 2022

This may be by design, but if there are more then 1 approver listed by label, the action passes with 1 approval.

Would it be possible to flag the approver individually under the label or specify by label all approvers required.

ex.
label:
- user1 (required)
- user2 (required)
- user3 (not required)

or a flag in the config
with:
all-approvers-required: 'true'
or a number
label(2):
- user1
- user2
- user3

@lvegerano lvegerano added the enhancement New feature or request label Aug 30, 2022
@lvegerano
Copy link
Owner

Hi @kennedyi. This is by design. I like the all-approvers-required: 'true' approach. It will take me some time to implement this but I welcome PRs 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants